Fix: Add missing --agent_engine_id option to adk deploy cloud_run command #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the --agent_engine_id option to the deploy cloud_run CLI command that was documented but not implemented. This allows users to connect their deployed agent to a Vertex AI Agent Engine for session persistence. Part of google#303
Update the Dockerfile template to use the agent_engine_id parameter by converting it to the required session_db_url format. This enables proper connection to Vertex AI Agent Engine when deploying to Cloud Run. Fixes google#303
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issue #303 by implementing the
--agent_engine_idoption for theadk deploy cloud_runcommand, which was documented but not recognized when executing the command.Changes made:
--agent_engine_idoption to the CLI parser for thedeploy cloud_runcommandsession_db_urlformatImplementation Approach
The implementation converts the provided
agent_engine_idinto the appropriatesession_db_urlformat (agentengine://your-agent-engine-id) to properly connect to Vertex AI Agent Engine for session persistence.Testing Status
I'm submitting this as a draft PR first. I plan to:
Any testing guidance from the team would be appreciated.
Fixes #303 (when complete)