Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .pre-commit-hooks.yaml to allow be run as a pre-commit hook #160

Closed
wants to merge 1 commit into from

Conversation

XuehaiPan
Copy link
Contributor

As per the title, users can use addlicense as a pre-commit hook:

# .pre-commit-config.yaml

repos:
  - repo: https://github.com/XuehaiPan/addlicense
    rev: '0a8669'
    hooks:
      - id: addlicense
        args: [-check, -l, apache, -c, "Some Team. All Rights Reserved."]

@C-Loftus
Copy link

C-Loftus commented Feb 3, 2025

Think this can probably be merged right? Looks like everything is all set unless I am missing something

Copy link
Contributor

@mco-gh mco-gh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@mco-gh
Copy link
Contributor

mco-gh commented Feb 3, 2025

Looks like you need an approving reviewer.
@willnorris ?

@willnorris
Copy link
Collaborator

@C-Loftus is there a meaningful difference between this and #138? Is the syntax in that pr still valid? I kinda like that one since it also adds docs.

@mco-gh : oh crap, am I the last person left with access? Well that's not good. You know, removing access when people left the company seemed to make sense at the time, but now I'm not so sure 😕 Do you know who's left that could take this over? I'm not really interested in maintaining long-term since I haven't used it in years

@mco-gh
Copy link
Contributor

mco-gh commented Feb 5, 2025

Hi @willnorris Yes, I lost access when I left Google in November. I don't know anyone else who would want to take this over so I think the ball is now in your court.

@C-Loftus
Copy link

C-Loftus commented Feb 5, 2025

@C-Loftus is there a meaningful difference between this and #138? Is the syntax in that pr still valid? I kinda like that one since it also adds docs.

Yes #138 looks great to me. I tested that PR out at internetofwater/scheduler#89 and you can see it applies the license fine. pre-commit output shows all success in a pipeline of other hooks as well.

Would be great if we could merge one of these so it doesn't fall through the cracks. Should be just a one file change without adding any burden on maintainers and then a lot of similar issues/old PRs requesting pre-commit can be simultaneously closed up.

@willnorris
Copy link
Collaborator

Closing in favor of #138 which is now merged

@willnorris willnorris closed this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants