Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you so much for making this library!
I was trying to run baselines using this library's "conv_encoder" architecture for the VAE and noticed that that architecture (including in the publicly available models at, for example, https://storage.googleapis.com/disentanglement_lib/unsupervised_study_v1/0.zip) don't seem to match the architecture described in https://arxiv.org/pdf/1811.12359.pdf in Table 2 of the appendix.
In particular, it looks like the last two Conv2D embedding layers have a kernel of 2x2 instead of 4x4.
I have no idea if it makes any important difference, but my intuition is telling me that 4x4 might make more sense (as shown in the attached pull request), so will probably make that change on my end. I just wanted to reach out and see if you would possibly have time to check my thought process there.
Thanks so much!