Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal links as relative one #290

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Conversation

Giom-V
Copy link
Collaborator

@Giom-V Giom-V commented Sep 13, 2024

  • Fixing internal links in latest modified notebooks
  • Updating template with relative links and instructions regarding links
  • Adding a "Next Steps" section in the template

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Giom-V Giom-V requested a review from markmcd September 16, 2024 08:05
@Giom-V
Copy link
Collaborator Author

Giom-V commented Sep 16, 2024

The only lint fail in related to the template, which I think is OK to have lint violations.

@Giom-V Giom-V marked this pull request as ready for review September 16, 2024 08:13
@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:quickstarts Issues/PR referencing quickstarts folder labels Sep 16, 2024
@markmcd markmcd merged commit 370477c into google-gemini:main Sep 16, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:quickstarts Issues/PR referencing quickstarts folder status:awaiting review PR awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants