Rationale for no leading space in //nolint:mylinter?

[sebastien-rosset]

The nolintlint linter requires there is no leading space before nolint. For example:

- // nolint: gocyclo
+ //nolint: gocyclo
func myBigFunc() error {

The rule was introduced in #837. Then it became a hard rule, as discussed briefly here: #1658 (comment)

However, this seems to go against the new go formatting rules introduced in gofmt version 1.19. For example, if the //nolint: comment is above a function, then gofmt will automatically add a leading space. The following code will make nolintlint happy:

//nolint: gocyclo
func myBigFunc() error {

But if you run gofmt version 1.19, the code will be reformatted as shown below, and now nolintlint will complain there is a leading space.

// nolint: gocyclo
func myBigFunc() error {

[ldez]

Hello,

nolint is a directive, not a comment, the new Go fmt adds a space before a comment, not before a directive.

The option allow-leading-space has been dropped.

The syntax of directives is: //[a-zA-Z]+:[a-zA-Z].*.
The spaces around : and after the // must be removed.

I already explained that in all the linked issues of #1658

[bombsimon]

I cannot reproduce this, this is the result for me.

$ go1.19.1 version
go version go1.19.1 linux/amd64

$ cat main.go
package main

//nolint:gocyclo // reason why
func main() {}

//nolint: gocyclo // reason why
func notmain() {}

$ git diff
diff --git a/main.go b/main.go
index e3afcb2..d4e6c49 100644
--- a/main.go
+++ b/main.go
@@ -3,5 +3,5 @@ package main
 //nolint:gocyclo // reason why
 func main() {}

-//nolint: gocyclo // reason why
+// nolint: gocyclo // reason why
 func notmain() {}

[ldez]

I have the behavior as @bombsimon.

The directive formal definition: golang/go#37974 (comment)

[sebastien-rosset]

Presumably you typed git diff after typing gofmt -w ., right? (with gofmt 1.19.1)

[bombsimon]

Yes, I typed them in the order I pasted them. The diff was to show what gofmt changed which was only the directive with a space after the colon.

[ldez]

yes