Revive settings in config not being honored

[azeemshaikh38]

Hi my golangci-lint config file looks this:

linters:
  disable-all: true
  enable:
    ...
    - revive
    ...
linters-settings:
  ...
  revive:
    ignore-generated-header: true
    severity: warning
    enableAllRules: true
    rules:
    - name: package-comments
    - name: exported
  ...

But the revive rules (specifically package-names and exported) don't seem to be running (I expect a failure but see no warn/errors). Could someone tell me if my config is wrong and if so how I should fix it?

[ldez]

Hi,

package-names and exported are excluded by default:

golangci-lint/pkg/config/issues.go

Lines 80 to 103 in bbf0450

	{
	ID: "EXC0012",
	Pattern: `exported (.+) should have comment( \(or a comment on this block\))? or be unexported`,
	Linter: "revive",
	Why: "Annoying issue about not having a comment. The rare codebase has such comments",
	},
	{
	ID: "EXC0013",
	Pattern: `package comment should be of the form "(.+)...`,
	Linter: "revive",
	Why: "Annoying issue about not having a comment. The rare codebase has such comments",
	},
	{
	ID: "EXC0014",
	Pattern: `comment on exported (.+) should be of the form "(.+)..."`,
	Linter: "revive",
	Why: "Annoying issue about not having a comment. The rare codebase has such comments",
	},
	{
	ID: "EXC0015",
	Pattern: `should have a package comment, unless it's in another file for this package`,
	Linter: "revive",
	Why: "Annoying issue about not having a comment. The rare codebase has such comments",
	},

[azeemshaikh38]

Thanks for the quick response! I had seen that. But this PR (#1938) gave me the impression that users are still allowed to use these rules if specified explicitly? Is that not correct?

[azeemshaikh38]

Specifically this comment - #1938 (comment)

[bombsimon]

The PR just moved the excludes from the Revive implementation to the default excludes where all the other excluded rules are. You still need to use --exclude-use-default=false (or in the config file) to get these errors.

[azeemshaikh38]

Ah makes sense. Now it works, thanks!