Change staticcheck severity to warning

[DONSA]

Hi,

I deprecated some methods in my code and now the linter is complaining:

internal/graphql/resolver.go:1318:23: SA1019: measurement.TotalWeight is deprecated: It will be deleted (staticcheck)

I think this should be a warning, not an error. There's any way to change it?

I tried this without success since the command is still returning exit code 1:

severity:
  default-severity: error
  case-sensitive: false
  rules:
    - linters:
        - staticcheck
      severity: warning

[ldez]

Hi,

The severity configuration allows handling a dedicated field, called severity, in some output format

The severity configuration doesn't change the exit code.

I recommend adding an exclude rule:

issues:
  exclude-rules:
    - linters:
        - staticcheck
      text: "SA1019: measurement.TotalWeightStore is deprecated"

[DONSA]

I still want to be warned for those deprecated fields, I just don't want my pipeline to fail.
Apparently there's no way around it, is either on or off.

[thebeline]

@DONSA - I was interested in similar behavior. I have a PR in that should add that ability, let me know if that's the kind of behavior you are referring to.

golangci/golangci-lint-action#198

[DONSA]

That's exactly it. I will keep an eye on it 👍

[thebeline]

@DONSA - The mentioned PR has been replaced by golangci/golangci-lint-action#207.

That new PR does also include the desired behavior, wither by setting a linter's severity to ignore, or by setting the failure-level to the desired failing severity.

It additionally allows for a notice severity, which will still be shown in the logs, but can be set to passing by setting the failure-level to warning.

[DONSA]

Got a bit lost because #207 is pointing to a PR on this repo, not golangci/golangci-lint-action#207. Thanks for mentioning it anyway.
I can see you've close it a couple of hours ago. Do you still have plans to get it merged?

[skormos]

Finally grokking severity, seems like there are one of three options:

1. Run golangci-lint twice with two different files and --issues-exit-code flag set to 0.
2. Wrapping the call to golangci-lint with the flag --out-format that uses a format which includes severity, and parsing for severities.
3. Run all the linters individually.

I suppose option 2 is not bad, considering it can be a standard format, but this seems more manual than it should be. 😞