Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 [Feature]: Adopt testcontainers-go for all the storage layers #1507

Open
6 of 29 tasks
mdelapenya opened this issue Aug 21, 2024 · 1 comment
Open
6 of 29 tasks

Comments

@mdelapenya
Copy link
Contributor

mdelapenya commented Aug 21, 2024

Feature Description

After #1506, let'd adopt testcontainers-go for integration testing of the storage layers.

For those technologies having a tc-go module (see https://testcontainers.com/modules/?language=go), let's use the module; for the rest, let's use the GenericContainer approach.

PRs to raise

Checklist:

  • I agree to follow Fiber's Code of Conduct.
  • I have checked for existing issues that describe my suggestion prior to opening this one.
  • I understand that improperly formatted feature requests may be closed without explanation.
@the-real-i9
Copy link
Contributor

the-real-i9 commented Feb 2, 2025

Hi @mdelapenya @gaby 🙇‍♂️. Can I submit a PR?

I've submitted a PR for Neo4j storage driver, which uses testcontainers-go, that's near approval.

Any further necessary steps after integrating the feature? I'm thinking I'll need to remove the docker run step for the target storage driver in the benchmark.yml workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants