-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fixes #177
base: master
Are you sure you want to change the base?
Various fixes #177
Conversation
oh, this looks actually super great!! |
Turns out there was an issue I missed and caught when trying to serialize. |
Also I removed removing the setter in JMS definition. |
Here is a list of changes I have made (hopefully I did not forget something):
Note that all my work is based on converting XZuFi 2.3.
So far everything seems to work as expected and soon I will be using generated classes and (de)serialization in customer code, which will in it self be a test if I broke something 😄
Oh and another thing, if you run the tests (all of them) it might happen that OTA tests fail but it seems that it is a bug in JMS as one interface defines "parse(): array" but class implementing it returns a string.