[Web] Fix cut-copy-paste #105845
Open
[Web] Fix cut-copy-paste #105845
+106
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamscott
force-pushed
the
web-fix-copy-and-paste
branch
from
75b421f to
b2dd7fd
Compare
adamscott
changed the title
adamscott
force-pushed
the
web-fix-copy-and-paste
branch
from
b2dd7fd to
4f2e3c2
Compare
MewPurPur
reviewed
Apr 28, 2025
Comment on lines
+521
to
+532
| switch (event.key) { | ||
| // Preventing default for clipboard shortcuts prevent | ||
| // the Clipboard API to actually being triggered. | ||
| // This makes it impossible to use {Ctrl,Cmd}-{X,C,V} keyboard shortcuts. | ||
| case 'x': | ||
| case 'c': | ||
| case 'v': | ||
| return false; | ||
| default: | ||
| return true; | ||
| } |
There was a problem hiding this comment.
The pressing of the Shift key may change the key of the event too. For example, pressing B generates key: "b", while simultaneously pressing Shift generates key: "B".
From https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/shiftKey and it seems relevant.
What about other shortcuts like Ctrl+Insert and Shift+Insert (idk if they are available everywhere but I can use them on Linux)?
adamscott
force-pushed
the
web-fix-copy-and-paste
branch
from
4f2e3c2 to
57c5bbb
Compare
adamscott
force-pushed
the
web-fix-copy-and-paste
branch
from
57c5bbb to
3cc99a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Believe it or not, copy-cut-paste on the Web platform seems to be completely broken. (I mean cut/copy/paste from outside to the game or from the game to outside.) Try it out. This PR fixes this.
Capture.video.du.2025-04-27.15-24-28.mp4
The issue is caused by the fact that we use
event.preventDefault()for every key input. This makes it impossible for the browser to actually trigger and dispatch theClipboardEventneeded to read the browser's clipboard. It is only available on transient user activation due to security considerations.So, I've added exceptions for {Ctrl,Cmd}-{X,C,V} (ctrl/cmd depends on the host). Keyboard-based copy/cut/paste aren't prevented by default, and this fixes the issues with copy/pasting.
So, it will be possible to copy/paste code from and to the browser. Very useful for code editors.