Skip expensive ambient light computation on fully metallic materials #103854
+736
−719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tygyh
force-pushed
the
metallic-smooth-skip-ambient-computation
branch
5 times, most recently
from
d6178fb to
cca9e52
Compare
This improves performance significantly in scenes that have fully metallic materials (metallic = 1.0). Fully metallic *and* smooth materials (roughness = 1.0, metallic = 1.0) bring further performance improvements by also disabling shadow map sampling.
tygyh
force-pushed
the
metallic-smooth-skip-ambient-computation
branch
from
cca9e52 to
7c4f755
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #58635
Description
This improves performance significantly in scenes that have fully metallic materials (metallic = 1.0).
Fully metallic and smooth materials (roughness = 1.0, metallic = 1.0) bring further performance improvements by also disabling shadow map sampling.