Add auto translate mode for items in PopupMenu and OptionButton
#103848
+156
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothyqiu
added
bug
enhancement
topic:editor
topic:gui
cherrypick:4.4
KoBeWi
reviewed
Mar 9, 2025
| @@ -612,6 +613,7 @@ ShaderCreateDialog::ShaderCreateDialog() { | |||
| // Modes. | |||
|
|
|||
| mode_menu = memnew(OptionButton); | |||
| mode_menu->set_auto_translate_mode(AUTO_TRANSLATE_MODE_DISABLED); | |||
There was a problem hiding this comment.
The modes could be translated tbh.
But right now there is no way to expose them for translation.
KoBeWi
reviewed
Mar 9, 2025
|
Button text does not respect item auto-translation: godot.windows.editor.dev.x86_64_1Uk3TJF0UH.mp4 |
KoBeWi
reviewed
Mar 9, 2025
Added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make i18n for popup menus easier if only some items need auto translation. Similar to #97519 and #97353.
For example, the
Editor / Layoutsubmenu has to translate shortcut names (Save Layout, Load Layout, etc) but should not translate custom layout names. Currently, all items in this submenu are not translated as a result of #99158.Also made some common popup menus in the editor to better utilize (per-item) auto translation mode.