Fix: Prevent PackedScene duplicate signal connection for CONNECT_PERSIST #103846
+6
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Prevent PackedScene duplicate signal connection for CONNECT_PERSIST occured in issue #103453
Issue
SceneState::instantiate
callsconnect()
, it triggers a "Signal already connected" error.Solution
Object::connect()
to check for CONNECT_PERSIST before reporting duplicate connections.Note:
This is my first PR to the Godot project. If there are any issues or areas for improvement, please let me know—I’m happy to make adjustments and learn from your feedback! Thank you for your patience and guidance.