Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CurveEdit not notifying about all changes #103840

Closed
wants to merge 1 commit into from

Conversation

passivestar
Copy link
Contributor

Closes #103831

Unlike Curve::set_point_value(), Curve::set_point_offset() doesn't mark curve as dirty which causes problems with CurveEdit::set_point_position() that calls them out of order and causes CurveTexture resource to not use the latest data of its Curve

This could be solved by adding mark_dirty() to Curve::set_point_offset but that would double the amount of calls to heavy CurveTexture::_update. So instead we're reversing the order of calls in CurveEdit::set_point_position. I made sure set_point_value is using the correct index (it's known in advance because drag has already happened)

@aryan-11825114
Copy link
Contributor

I also opened a P.R. to close this issue, see #96296.
Also closes #95752.

@passivestar passivestar closed this Mar 9, 2025
@passivestar passivestar deleted the fix-curve-update branch March 9, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpredictable behavior of CurveEdit editor widget
2 participants