Fix CurveEdit not notifying about all changes #103840
Closed
+5
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #103831
Unlike
Curve::set_point_value()
,Curve::set_point_offset()
doesn't mark curve as dirty which causes problems withCurveEdit::set_point_position()
that calls them out of order and causesCurveTexture
resource to not use the latest data of itsCurve
This could be solved by adding
mark_dirty()
toCurve::set_point_offset
but that would double the amount of calls to heavyCurveTexture::_update
. So instead we're reversing the order of calls inCurveEdit::set_point_position
. I made sureset_point_value
is using the correct index (it's known in advance because drag has already happened)