Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing get_data when calling CFStringCreateWithCString in macos_utils #103837

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

a-johnston
Copy link
Contributor

@a-johnston a-johnston commented Mar 8, 2025

Related to #101293

Noticed local builds failing with scons module_mono_enabled=yes dev_mode=yes dev_build=yes (but not scons dev_mode=yes dev_build=yes for some reason) after rebasing earlier today and bisected to the above pr. I assume this instance was missed as it's behind MACOS_ENABLED. The build error is:

[ 56%] modules/mono/utils/macos_utils.cpp:41:26: error: no matching function for call to 'CFStringCreateWithCString'
   41 |         CFStringRef bundle_id = CFStringCreateWithCString(nullptr, p_bundle_id.utf8(), kCFStringEncodingUTF8);
      |                                 ^~~~~~~~~~~~~~~~~~~~~~~~~
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.1.sdk/System/Library/Frameworks/CoreFoundation.framework/Headers/CFString.h:181:13: note: candidate function not viable: no known conversion from 'CharString' to 'const char *' for 2nd argument
  181 | CFStringRef CFStringCreateWithCString(CFAllocatorRef alloc, const char *cStr, CFStringEncoding encoding) CF_FORMAT_ARGUMENT(2);
      |             ^                                               ~~~~~~~~~~~~~~~~

@a-johnston a-johnston requested a review from a team as a code owner March 8, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant