Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RenderingDevice: Delay expensive operations to get_perf_report #103814

Merged

Conversation

darksylinc
Copy link
Contributor

The function update_perf_report() is expensive and is called every frame.
Most of it is not necessary unless the user calls get_perf_report

Affects #102173

The function update_perf_report() is expensive and is called every
frame.
Most of it is not necessary unless the user calls get_perf_report

Affects godotengine#102173
@darksylinc darksylinc marked this pull request as ready for review March 8, 2025 14:26
@darksylinc darksylinc requested a review from a team as a code owner March 8, 2025 14:26
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Nice touch to move the string ops too

@clayjohn clayjohn added this to the 4.5 milestone Mar 8, 2025
@akien-mga akien-mga changed the title Delay expensive operations to get_perf_report Delay expensive operations to get_perf_report Mar 8, 2025
@akien-mga akien-mga changed the title Delay expensive operations to get_perf_report RenderingDevice: Delay expensive operations to get_perf_report Mar 8, 2025
@Repiteo Repiteo merged commit bf60318 into godotengine:master Mar 9, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Mar 9, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants