FindReplaceBar: Fix "Replace (All)" buttons repositioning, improve "Hide" button visual feedback
#103806
+12
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…"Hide" button visual feedback "Replace" and "Replace All" buttons now do not change their position depending on the availability of search results. Additional changes: - `VBoxContainer *vbc_lineedit` declaration has been removed from the header because it is not used outside the `FindReplaceBar` constructor. - `hide_button` was changed from `TextureButton` to `Button` for consistency - this allows to visually see the feedback when hovering and pressing and also not set its icon 3 times instead of 1.
arkology
changed the title
FindReplaceBar: Fix "Replace (All)" buttons repositioning, improve …FindReplaceBar: Fix "Replace (All)" buttons repositioning, improve "Hide" button visual feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Replace" and "Replace All" buttons now do not change their position depending on the availability of search results.
This is how it was before (look at "Replace (All)" buttons):
Godot_v4.4-stable_win64_z4HhUkw1Ah.mp4
This is how it looks now:
Godot_v4.4-stable_win64_SIZU2l6Nai.mp4
Additional changes:
VBoxContainer *vbc_lineeditdeclaration has been removed from the header because it is not used outside theFindReplaceBarconstructor.hide_buttonwas changed fromTextureButtontoButtonfor consistency with other buttons - this allows to visually see the feedback when hovering and pressing and also not set its icon 3 times instead of 1. But at the same time, it takes up a little more space around the icon - I think it should be fine.