Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using deprecated mb_convert_encoding #2733

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from
Draft

Avoid using deprecated mb_convert_encoding #2733

wants to merge 3 commits into from

Conversation

brianhogg
Copy link
Contributor

@brianhogg brianhogg commented Aug 15, 2024 •
edited
Loading

Description

Avoids mb_convert_encoding warning with a video on a course.

Fixes #2672

How has this been tested?

Manually

Checklist:

  • This PR requires and contains at least one changelog file.
  • My code has been tested.
  • My code passes all existing automated tests.
  • My code follows the LifterLMS Coding & Documentation Standards.

@brianhogg brianhogg added this to the Next Available Release milestone Aug 15, 2024
@brianhogg brianhogg marked this pull request as draft August 15, 2024 20:57
@brianhogg
Copy link
Contributor Author

Not all test cases pass:

Captura de pantalla 2024-08-15 a las 4 58 46 p  m

@brianhogg brianhogg removed this from the Next Available Release milestone Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ideadude ideadude Awaiting requested review from ideadude ideadude is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Development
Status: Awaiting Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brianhogg