Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect label for page selection on account settings tab #2731

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Fix incorrect label for page selection on account settings tab #2731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c73777
Adding placeholder.
brianhogg Aug 15, 2024
443b620
Adding changelog.
brianhogg Aug 15, 2024
7083baf
Merge branch 'dev' into fix/incorrect-label-for-page-selection-on-acc…
brianhogg Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changelogs/fix_incorrect-label-for-page-selection-on-account-settings-tab.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
significance: patch
type: fixed
links:
- "#2708"
entry: Fixes placeholder label on the Dashboard Page selection dropdown.
5 changes: 2 additions & 3 deletions includes/admin/settings/class.llms.settings.accounts.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@ public function get_settings() {
'class' => 'llms-select2-post',
'type' => 'select',
'custom_attributes' => array(
'data-post-type' => 'page',
'data-post-type' => 'page',
'data-placeholder' => __( 'Select a page', 'lifterlms' ),
),
'options' => llms_make_select2_post_array( get_option( 'lifterlms_myaccount_page_id', '' ) ),
),
Expand Down Expand Up @@ -372,7 +373,6 @@ public function get_settings() {
* @param array $account_settings The account page settings.
*/
return apply_filters( "lifterlms_{$this->id}_settings", $account_settings );

}

/**
Expand All @@ -385,7 +385,6 @@ public function get_settings() {
protected function set_label() {
return __( 'Accounts', 'lifterlms' );
}

}

return new LLMS_Settings_Accounts();
Loading