Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove placeholder image from media protection & wordpress.com cache fixes #2711

Merged
merged 9 commits into from
Aug 9, 2024

Conversation

brianhogg
Copy link
Contributor

@brianhogg brianhogg commented Aug 7, 2024

Description

Removes the placeholder image functionality in case there might be a loop created when trying to serve + save that file.

Also modifies the cache method since wordpress.com cache returns null as boolean false

Fixes #2713

How has this been tested?

Manually.

Checklist:

  • This PR requires and contains at least one changelog file.
  • My code has been tested.
  • My code passes all existing automated tests.
  • My code follows the LifterLMS Coding & Documentation Standards.

@ideadude ideadude added this to the Next Available Release milestone Aug 7, 2024
@ideadude ideadude merged commit 037e27b into dev Aug 9, 2024
34 of 40 checks passed
@ideadude ideadude deleted the fix/remove-placeholder-image branch August 9, 2024 14:00
@brianhogg brianhogg changed the title Remove placeholder image from media protection Remove placeholder image from media protection & wordpress.com cache fixes Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants