Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/quiz resume #2519

Open
wants to merge 81 commits into
base: dev
Choose a base branch
from
Open

Feature/quiz resume #2519

wants to merge 81 commits into from

Conversation

eri-trabiccolo
Copy link
Collaborator

@eri-trabiccolo eri-trabiccolo commented Sep 5, 2023 •
edited
Loading

Quiz Resume feature

eri-trabiccolo and others added 30 commits July 10, 2023 10:04
@eri-trabiccolo
initial work
f897916
@eri-trabiccolo
Add changelogs
1b836de
@eri-trabiccolo
push quiz.js
9463363
@eri-trabiccolo
Update llms-quiz.js
ae96a26 
remove debug line
@actuallyakash
Added resume button with filter
99805bb
@actuallyakash
added filter for resuming attempt
96cfab4
@actuallyakash
disable resume button after quiz is resumed
305b1e3
@actuallyakash
fixed a bug with showing previous question answers
d694949
@actuallyakash
added resume support for blank questions
c842afd
@actuallyakash
added changelogs and updated docblocks
61e6093
@actuallyakash
removed leave page confirmation alert
8b8cdf5
@actuallyakash
updated button string for restarting quiz
aecd38c
@actuallyakash
removing 'resumed' quiz if restart quiz is clicked
65ddd46
@actuallyakash
added Action schedule for quiz resume
1144f25
@actuallyakash
added support for images in tinyMCE
8951f97
@actuallyakash
fixed warning issue when quiz is not resumable
3dfe82e
@actuallyakash
added changelogs
3c3dc6c
@actuallyakash
abstracted the start_quiz() with resume_quiz()
19fa143
@actuallyakash
minor fixes
ee7bacb
@actuallyakash
minor typos
e220e17
@actuallyakash
Revert "added support for images in tinyMCE"
f80c24e 
This reverts commit 8951f97.
@eri-trabiccolo
fix tyoo in the changelogs
1b30ac2
@eri-trabiccolo
fix can_be_resumed_by_student logic
3ed5d30
@eri-trabiccolo
fix some version tags
6f00dd6
@eri-trabiccolo
Merge branch 'feature/quiz-resume' into feature/quiz-resume-akash
3f47803
@actuallyakash @eri-trabiccolo
Apply suggestions from code review
97611e0 
Co-authored-by: Rocco Aliberti <raliberti84@gmail.com>
@actuallyakash
code improvements
8b474cb
@actuallyakash
fix failing tests
4d601b0
@actuallyakash
hide grades/answers/points/clarifications for incomplete resumed attempt
ea4cc8b
@actuallyakash
minor fixes
21969b4
brianhogg and others added 29 commits August 22, 2024 11:24
@brianhogg
Merge branch 'dev' into feature/quiz-resume
05d1467
@brianhogg
Removing unused variable.
648884e
@brianhogg
Removed most changelogs. Fixed resume quiz button text filter (llms v…
8e62964 
…s lifterlms). Removed filters to change resumability (except for resume expiration time).
@brianhogg
Saves the last question on Previous. However if you hit Previous on t…
292d6be 
…he last question you cannot resume since it tries to start a new attempt.
@brianhogg
When resuming quiz, show the question they were last on instead of th…
9504456 
…e question after the last answered question to avoid any validation errors.
@brianhogg
Separating Restart from Resume button with a notice.
3ec2665
@brianhogg
Resume message improvements, avoid asking to reload or sending Comple…
b2b443f 
…te Quiz signal when exiting.
@brianhogg
Avoid sending the "complete quiz" action on refresh if the quiz is re…
d29c385 
…sumeable.
@brianhogg
Check if the quiz is the latest attempt to see if it can be resumed.
43304d9
@brianhogg
Avoid showing warnings if there's no end date recorded.
6510531
@brianhogg
Explicitly end the previous quiz attempt if Restarting the quiz inste…
c2fe063 
…ad of Resuming.
@brianhogg
Don't show "you can resume..." message in admin.
5fead71
@brianhogg
End the quiz attempt when disabling resumability.
eaecaed
@brianhogg
Prevent answers being saved or changed if the attempt is not incomplete.
91687c3
@brianhogg
Reverting label change.
c10e547
@brianhogg
Fix expiry calculation to take timezone into account. Switch expiry t…
08700db 
…ime value to hours vs. days.
@brianhogg
Check if a resumeable quiz can be resumed before allowing an answer t…
bbd8d8b 
…o be saved, to take things like resume expiry time into account.
@brianhogg
Refactor. Removing "what" comment.
85e4525
@brianhogg
Additional checks for getting a question. Refactor to remove if/else.
7c0552b
@brianhogg
Actually adding image support for question result clarifications.
4b68549
@brianhogg
Undo spacing changes.
09ceb97
@brianhogg
Escaping.
2f3c91c
@brianhogg
Fixing last attempt key to check if there is a last attempt first.
338a904
@brianhogg
Changing test. We now check for status of "incomplete" before allowin…
4c0ae00 
…g a question to be answered, which the quiz already isn't ("pass").
@brianhogg
Fixing answer check.
8f50201
@brianhogg
Merge branch 'dev' into feature/quiz-resume
9b8ee34
@brianhogg
Show progress in the progress bar on quiz resume.
3bbc790
@brianhogg
Removing error log.
9b2de51
@brianhogg
Removing "what" comments.
29bf711
@brianhogg brianhogg added this to the Next Available Release milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianhogg brianhogg brianhogg left review comments

@ideadude ideadude Awaiting requested review from ideadude ideadude is a code owner

Assignees

@brianhogg brianhogg

Labels
Severity: Normal
Projects
Development
Status: Awaiting Review
Milestone
Next Available Release
Development

Successfully merging this pull request may close these issues.
3 participants
@eri-trabiccolo @actuallyakash @brianhogg