Skip to content

Commit

Permalink
More escaping of inner string. Wait to escape aria label until the ou…
Browse files Browse the repository at this point in the history
…tput line. (#2872)
  • Loading branch information
brianhogg authored Feb 5, 2025
1 parent 6d2a643 commit 95565d4
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,8 @@ public function manage_post_row_actions( $actions, $post ) {

$link = get_permalink( $post );
if ( $link ) {
$label = sprintf( esc_attr__( 'View "%s"', 'lifterlms' ), $post->post_title );
$actions['view'] = sprintf( '<a href="%1$s" rel="bookmark" aria-label="%2$s">%3$s</a>', esc_url( $link ), $label, __( 'View', 'lifterlms' ) );
$label = sprintf( __( 'View "%s"', 'lifterlms' ), $post->post_title );
$actions['view'] = sprintf( '<a href="%1$s" rel="bookmark" aria-label="%2$s">%3$s</a>', esc_url( $link ), esc_attr( $label ), esc_html__( 'View', 'lifterlms' ) );
}

return $actions;
Expand Down

0 comments on commit 95565d4

Please sign in to comment.