Fix incorrect label for page selection on account settings tab (#2731)

* Adding placeholder. * Adding changelog.
gocodebox · Aug 20, 2024 · 67cfed1 · 67cfed1
1 parent 7cc0130
commit 67cfed1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/.changelogs/fix_incorrect-label-for-page-selection-on-account-settings-tab.yml b/.changelogs/fix_incorrect-label-for-page-selection-on-account-settings-tab.yml
@@ -0,0 +1,5 @@
+significance: patch
+type: fixed
+links:
+  - "#2708"
+entry: Fixes placeholder label on the Dashboard Page selection dropdown.
diff --git a/includes/admin/settings/class.llms.settings.accounts.php b/includes/admin/settings/class.llms.settings.accounts.php
@@ -71,7 +71,8 @@ public function get_settings() {
 				'class'             => 'llms-select2-post',
 				'type'              => 'select',
 				'custom_attributes' => array(
-					'data-post-type' => 'page',
+					'data-post-type'   => 'page',
+					'data-placeholder' => __( 'Select a page', 'lifterlms' ),
 				),
 				'options'           => llms_make_select2_post_array( get_option( 'lifterlms_myaccount_page_id', '' ) ),
 			),
@@ -372,7 +373,6 @@ public function get_settings() {
 		 * @param array $account_settings The account page settings.
 		 */
 		return apply_filters( "lifterlms_{$this->id}_settings", $account_settings );
-
 	}
 
 	/**
@@ -385,7 +385,6 @@ public function get_settings() {
 	protected function set_label() {
 		return __( 'Accounts', 'lifterlms' );
 	}
-
 }
 
 return new LLMS_Settings_Accounts();