Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beds 880/adding many validators to dashboard freezes #1123

Merged

Conversation

Eisei24
Copy link
Contributor

@Eisei24 Eisei24 commented Nov 12, 2024

No description provided.

Copy link

cloudflare-workers-and-pages bot commented Nov 13, 2024

Deploying beaconchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0b25ef3
Status: ✅  Deploy successful!
Preview URL: https://2a99124c.beaconchain.pages.dev
Branch Preview URL: https://beds-880-adding-many-validat.beaconchain.pages.dev

View logs

Copy link
Contributor

@LuccaBitfly LuccaBitfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type changes lgtm, haven't looked at data access though

@Eisei24 Eisei24 force-pushed the BEDS-880/Adding_many_validators_to_dashboard_freezes branch from d510286 to bac8e1e Compare November 13, 2024 13:53
-Added batch behaviour and simpler queries
-Fixed missing tx commit
-Added insert count to standard insert
-Get the count of inserted validators
-Get the inserted count for each query
-Get the total amount of rows not just inserted ones
-Removed test comments
-Returned the filled result
-Changed to return pubkeys instead of count
-Changed the return type from pubkey to index
-chore: convert ts types
@Eisei24 Eisei24 force-pushed the BEDS-880/Adding_many_validators_to_dashboard_freezes branch from bac8e1e to 0b25ef3 Compare November 13, 2024 14:02
@peterbitfly peterbitfly merged commit cf8264c into staging Nov 14, 2024
4 checks passed
@Eisei24 Eisei24 deleted the BEDS-880/Adding_many_validators_to_dashboard_freezes branch November 14, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants