BEDS 868/mock seed #1032
Merged
BEDS 868/mock seed #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
LuccaBitfly
commented
Oct 24, 2024
LuccaBitfly
commented
- refactor: pass and use context everywhere
- refactor: move context keys to types pkg
- feat: store dashboard id in context in archiving middleware
- feat: implement mock_seed query param
See: BEDS-868
See: BEDS-868
- avoids fetching from db twice when calling `handleDashboardId` both in archiving middleware and the actual handler See: BEDS-868
- allows for passind a seed when the is_mocked flag is being used, which will cause deterministic mocked data. - useful for some auth sensitive endpoints which rely on fetched data staying the same See: BEDS-868
LuccaBitfly
force-pushed
the
BEDS-868/mock-seed
branch
from
8319b21 to
7953736
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.