Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace group_offline with group_efficiency_below event #1005

Merged
merged 5 commits into from
Oct 22, 2024
Merged

feat: replace group_offline with group_efficiency_below event #1005

merged 5 commits into from
Oct 22, 2024

Conversation

LuccaBitfly
Copy link
Contributor

See: BEDS-847

@LuccaBitfly LuccaBitfly force-pushed the BEDS-847/group-efficiency branch from 23ad318 to 79cb565 Compare October 22, 2024 07:40
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Oct 22, 2024 •
edited
Loading

Deploying beaconchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: a26e2b4
Status: ✅  Deploy successful!
Preview URL: https://6378d636.beaconchain.pages.dev
Branch Preview URL: https://beds-847-group-efficiency.beaconchain.pages.dev

View logs

Eisei24
Eisei24 reviewed Oct 22, 2024
View reviewed changes
Copy link
Contributor

@Eisei24 Eisei24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor issues that can be changed now or later.

backend/pkg/api/data_access/notifications.go Outdated Show resolved Hide resolved
backend/pkg/api/types/user.go Outdated Show resolved Hide resolved
Eisei24
Eisei24 suggested changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@Eisei24 Eisei24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the broken query.

backend/pkg/api/data_access/notifications.go Outdated Show resolved Hide resolved
backend/pkg/api/data_access/notifications.go Show resolved Hide resolved
@LuccaBitfly LuccaBitfly force-pushed the BEDS-847/group-efficiency branch from 286f978 to 5eae00a Compare October 22, 2024 09:10
Eisei24
Eisei24 approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@Eisei24 Eisei24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LuccaBitfly LuccaBitfly merged commit df7d583 into staging Oct 22, 2024
5 checks passed
@LuccaBitfly LuccaBitfly deleted the BEDS-847/group-efficiency branch October 22, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eisei24 Eisei24 Eisei24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LuccaBitfly @Eisei24 @marcel-bitfly