feat: add dashboard name to dashboard settings response

See: BEDS-94
gobitfly · Oct 17, 2024 · 436ed6a · 436ed6a
1 parent 76bd9f3
commit 436ed6a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 0 deletions.
diff --git a/backend/pkg/api/data_access/notifications.go b/backend/pkg/api/data_access/notifications.go
@@ -1965,6 +1965,7 @@ func (d *DataAccessService) GetNotificationSettingsDashboards(ctx context.Contex
 		result = append(result, t.NotificationSettingsDashboardsTableRow{
 			IsAccountDashboard: setting.IsAccountDashboard,
 			DashboardId:        setting.DashboardId,
+			DashboardName:      setting.DashboardName,
 			GroupId:            setting.GroupId,
 			GroupName:          setting.GroupName,
 			Settings:           setting.Settings,

diff --git a/backend/pkg/api/types/notifications.go b/backend/pkg/api/types/notifications.go
@@ -242,6 +242,7 @@ type InternalPutUserNotificationSettingsAccountDashboardResponse ApiDataResponse
 type NotificationSettingsDashboardsTableRow struct {
 	IsAccountDashboard bool   `json:"is_account_dashboard"` // if false it's a validator dashboard
 	DashboardId        uint64 `json:"dashboard_id"`
+	DashboardName      string `json:"dashboard_name"`
 	GroupId            uint64 `json:"group_id"`
 	GroupName          string `json:"group_name"`
 	// if it's a validator dashboard, Settings is NotificationSettingsAccountDashboard, otherwise NotificationSettingsValidatorDashboard

diff --git a/frontend/types/api/notifications.ts b/frontend/types/api/notifications.ts
@@ -222,6 +222,7 @@ export type InternalPutUserNotificationSettingsAccountDashboardResponse = ApiDat
 export interface NotificationSettingsDashboardsTableRow {
   is_account_dashboard: boolean; // if false it's a validator dashboard
   dashboard_id: number /* uint64 */;
+  dashboard_name: string;
   group_id: number /* uint64 */;
   group_name: string;
   /**