fix: applied scaling to notification content

gobitfly · Oct 29, 2024 · 1fc7159 · 1fc7159
1 parent d078cab
commit 1fc7159
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/backend/pkg/notification/collection.go b/backend/pkg/notification/collection.go
@@ -695,11 +695,11 @@ func collectGroupEfficiencyNotifications(notificationsByUserID types.Notificatio
 					syncEfficiency.Valid = true
 				}
 
-				efficiency := utils.CalculateTotalEfficiency(attestationEfficiency, proposerEfficiency, syncEfficiency)
+				efficiency := utils.CalculateTotalEfficiency(attestationEfficiency, proposerEfficiency, syncEfficiency) / 100
 
-				log.Infof("efficiency: %v, threshold: %v", efficiency, groupDetails.Subscription.EventThreshold*100)
+				log.Infof("efficiency: %v, threshold: %v", efficiency*100, groupDetails.Subscription.EventThreshold*100)
 
-				if efficiency < groupDetails.Subscription.EventThreshold*100 {
+				if efficiency < groupDetails.Subscription.EventThreshold {
 					log.Infof("creating group efficiency notification for user %v, dashboard %v, group %v in epoch %v", userId, dashboardId, groupId, epoch)
 					n := &ValidatorGroupEfficiencyNotification{
 						NotificationBaseImpl: types.NotificationBaseImpl{

diff --git a/backend/pkg/notification/types.go b/backend/pkg/notification/types.go
@@ -260,7 +260,7 @@ func (n *ValidatorGroupEfficiencyNotification) GetEntitiyId() string {
 func (n *ValidatorGroupEfficiencyNotification) GetInfo(format types.NotificationFormat) string {
 	dashboardAndGroupInfo := formatPureDashboardAndGroupLink(format, n)
 	epoch := formatEpochLink(format, n.Epoch)
-	return fmt.Sprintf(`%s efficiency of %.2f%% was below the threshold of %.2f%% in epoch %s.`, dashboardAndGroupInfo, n.Efficiency, n.Threshold, epoch)
+	return fmt.Sprintf(`%s efficiency of %.2f%% was below the threshold of %.2f%% in epoch %s.`, dashboardAndGroupInfo, n.Efficiency*100, n.Threshold*100, epoch)
 }
 
 func (n *ValidatorGroupEfficiencyNotification) GetTitle() string {