Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/integrations: Open WebUI #12939

Merged
merged 10 commits into from
Feb 13, 2025
Merged

Conversation

nicedevil007
Copy link
Contributor

Details

And another one from me :) Hope this fits best from all my PRs now :)

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@nicedevil007 nicedevil007 requested a review from a team as a code owner February 5, 2025 16:11
Copy link

netlify bot commented Feb 5, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit be98bc6
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/67aa20bbaa5c3e000846b9e4

Copy link

netlify bot commented Feb 5, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit be98bc6
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/67aa20bb3b48c60008bf6200
😎 Deploy Preview https://deploy-preview-12939--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.69%. Comparing base (e2d6d38) to head (be98bc6).
Report is 39 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12939      +/-   ##
==========================================
+ Coverage   92.66%   92.69%   +0.02%     
==========================================
  Files         770      785      +15     
  Lines       38945    39580     +635     
==========================================
+ Hits        36090    36689     +599     
- Misses       2855     2891      +36     
Flag Coverage Δ
e2e 48.42% <ø> (-0.05%) ⬇️
integration 24.54% <ø> (-0.06%) ⬇️
unit 90.43% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dominic-r dominic-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nicedevil007 , thank you for yet another another another contribution recently! Here are a few things I noticed that would make this doc page better. Please do let me know if you have any questions!

website/integrations/services/open-webui/index.md Outdated Show resolved Hide resolved
website/integrations/services/open-webui/index.md Outdated Show resolved Hide resolved
website/integrations/services/open-webui/index.md Outdated Show resolved Hide resolved
website/integrations/services/open-webui/index.md Outdated Show resolved Hide resolved
website/integrations/services/open-webui/index.md Outdated Show resolved Hide resolved
website/integrations/services/open-webui/index.md Outdated Show resolved Hide resolved
nicedevil007 and others added 2 commits February 5, 2025 18:32
Co-authored-by: Dominic R <dominic@sdko.org>
Signed-off-by: NiceDevil <17103076+nicedevil007@users.noreply.github.com>
Signed-off-by: NiceDevil <17103076+nicedevil007@users.noreply.github.com>
nicedevil007 and others added 2 commits February 5, 2025 21:03
Co-authored-by: Dominic R <dominic@sdko.org>
Signed-off-by: NiceDevil <17103076+nicedevil007@users.noreply.github.com>
@tanberry
Copy link
Contributor

Thanks @nicedevil007 for this PR! Can you rerun the make website for linting, please; that check is failing, which causes the second one (the mark) to also fail. Thans!

@nicedevil007
Copy link
Contributor Author

Thanks @nicedevil007 for this PR! Can you rerun the make website for linting, please; that check is failing, which causes the second one (the mark) to also fail. Thans!

Oh sry missed this. Will do later, maybe 4-5hours when I'm back home :)

@nicedevil007
Copy link
Contributor Author

hope now it is correct :)

Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks again @nicedevil007! @dominic-r did you have any outstanding edits you saw?

@dominic-r
Copy link
Contributor

Hmmm nope Tana. looks good here

Copy link
Contributor

@dominic-r dominic-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again nicedevil

Comment on lines +56 to +61
:::note
Users are automatically created, but an administrator must update their role to at least **User** via the WebGUI.
To do so, log in as an administrator and access the **Admin Panel** (URL: <kbd>https://openwebui.company</kbd>/admin/users).
Click on the user whose role should be increased from **Pending** to at least **User**.
More details on how to administer Open WebUI can be found here <kbd>https://docs.openwebui.com/</kbd>.
:::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the docs, this can be managed by providing a custom claim with proper roles. It would be a better user experience to indicate that in the docs instead of manually requiring the admin to change the role every time a user is created.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya, this is absolutely true but I thought the aim of the docs on authentik should only get anyone to the point to be able to login and any additional configuration should be done by yourself. Otherwise we have to do an analysis for each service provider and write the same docs here as it is pointed out in each of the service providers' documentation.

I mean I can do it but I guess this going against the note that is in each guide right now. (Guide includes only settings that should be changed from default values....)

@tanberry @dominic-r should I do it or leave this version as it is right now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a bunch of places where we do provide that information, for instance the Grafana docs. IMO this should've made it in. At the very least, there should've been a pointer to that specific version in the upstream docs. If you're up for it, I'd love a follow up PRs with instructions for this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, while true that we can try to keep these integration instructions as generic as possible (to your point @nicedevil007 ), it's more important to provide docs that follow "best practices"... so if a best practice is to use a custom claim with proper roles, we should document that. At very least, mention it.

Would this work:

Users are automatically created, but an administrator must update their role to at least **User** via the WebGUI. Alternatively, you can use [OAuth role management](https://docs.openwebui.com/features/sso/#oauth-role-management) to configure the provider to return roles in the access token.

Apologies I merged this without seeing your comment @rissson.

@tanberry tanberry merged commit 4fe533a into goauthentik:main Feb 13, 2025
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants