Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lifecycle: much improved debugging experience #12804

Merged
merged 7 commits into from
Feb 1, 2025

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Jan 24, 2025

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested review from a team as code owners January 24, 2025 23:02
Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 6b48ee5
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/679d7f40b223110008a95214

Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 6b48ee5
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/679d7f40e06f830008337928

@authentik-automation
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 26%, saving 282.38 KB.

Filename Before After Improvement Visual comparison
website/docs/developer-docs/setup/debug_vscode.png 1.06 MB 805.20 KB -26.0% View diff

160 images did not require optimisation.

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 92.75%. Comparing base (7c944b9) to head (6b48ee5).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
authentik/lib/debug.py 25.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12804      +/-   ##
==========================================
- Coverage   92.75%   92.75%   -0.01%     
==========================================
  Files         769      770       +1     
  Lines       38929    38945      +16     
==========================================
+ Hits        36109    36122      +13     
- Misses       2820     2823       +3     
Flag Coverage Δ
e2e 48.61% <0.00%> (+0.04%) ⬆️
integration 24.59% <0.00%> (-0.02%) ⬇️
unit 90.37% <25.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 25, 2025

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-6b48ee5eabb0c45aedaee78ab92a9b0bd77f233a
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-6b48ee5eabb0c45aedaee78ab92a9b0bd77f233a

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu force-pushed the lifecycle/fix-debugger-setup branch from 4a40ac3 to 3db3c69 Compare January 25, 2025 00:48
@BeryJu BeryJu force-pushed the lifecycle/fix-debugger-setup branch from 3db3c69 to 4970093 Compare January 25, 2025 00:49
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu force-pushed the lifecycle/fix-debugger-setup branch from 9b07708 to 5f54a9a Compare February 1, 2025 01:38
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu removed the request for review from a team February 1, 2025 02:32
@BeryJu BeryJu merged commit 334e2c4 into main Feb 1, 2025
71 of 72 checks passed
@BeryJu BeryJu deleted the lifecycle/fix-debugger-setup branch February 1, 2025 02:35
@sirux88
Copy link
Contributor

sirux88 commented Feb 2, 2025

@BeryJu:
Is there a specific reason for the changes the last commit (6b48ee5).
If you keep the dot instead of the slash local debugging (in current working directory) and debugging in container should work (on the container working directory is '/')

@BeryJu
Copy link
Member Author

BeryJu commented Feb 2, 2025

@BeryJu: Is there a specific reason for the changes the last commit (6b48ee5). If you keep the dot instead of the slash local debugging (in current working directory) and debugging in container should work (on the container working directory is '/')

I did not work for me when testing this with a container running in compose, however this is a point that will be revisited in the future anyways as we want to move the root directory in the container to no longer copy a bunch of stuff directly into /

@sirux88
Copy link
Contributor

sirux88 commented Feb 2, 2025

@BeryJu: Is there a specific reason for the changes the last commit (6b48ee5). If you keep the dot instead of the slash local debugging (in current working directory) and debugging in container should work (on the container working directory is '/')

I did not work for me when testing this with a container running in compose, however this is a point that will be revisited in the future anyways as we want to move the root directory in the container to no longer copy a bunch of stuff directly into /

Hm strange this doesn't make sense with the docker files current state. I'll investigate your issue with the docker container and see if I can figure out what the problem is. If I can fix it I'll open a new PR and reference it here resp. there.

This needs to be done anyway if you want to move the files (somewhen) from /

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants