Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: fixes broken docLinks - url missing s #12789

Merged
merged 1 commit into from
Jan 23, 2025
Merged

web: fixes broken docLinks - url missing s #12789

merged 1 commit into from
Jan 23, 2025

Conversation

tanberry
Copy link
Contributor

@tanberry tanberry commented Jan 23, 2025

This PR fixes five broken links in the UI where docLinks point to an invalid url (/docs/user-sources/sources/property-mappings/expressions?utm_source=authentik)... the directory name is users-sources with an "s".

This fixes part of Issue #12766, the broken link part. We probably still need to add more content to the docs explaining that one needs to enter the property mapping, there is no automatic distraction and population. Some good ideas in the related PR.

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@tanberry tanberry requested a review from a team as a code owner January 23, 2025 20:46
Copy link

netlify bot commented Jan 23, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 9caa554
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/6792aaa637c66300083642f4

Copy link

netlify bot commented Jan 23, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 9caa554
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6792aaa67afe260008ca4750
😎 Deploy Preview https://deploy-preview-12789--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.76%. Comparing base (7163d33) to head (9caa554).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12789      +/-   ##
==========================================
- Coverage   92.76%   92.76%   -0.01%     
==========================================
  Files         769      769              
  Lines       38912    38912              
==========================================
- Hits        36098    36095       -3     
- Misses       2814     2817       +3     
Flag Coverage Δ
e2e 48.57% <ø> (-0.01%) ⬇️
integration 24.62% <ø> (ø)
unit 90.40% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-9caa5549639f92afcd5d26da2dca8d8bb5054f77
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-9caa5549639f92afcd5d26da2dca8d8bb5054f77

Afterwards, run the upgrade commands from the latest release notes.

Copy link
Contributor

@kensternberg-authentik kensternberg-authentik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward.

@tanberry tanberry merged commit fdc3de8 into main Jan 23, 2025
76 checks passed
@tanberry tanberry deleted the ui-link-fix branch January 23, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants