Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sources/oauth: fix authentication only being sent in form body #12713

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Jan 16, 2025

Details

closes #9895

See https://datatracker.ietf.org/doc/html/rfc6749#section-2.3.1

We previously only sent credentials as part of the body which according to the RFC is optional, however sending the credentials as Authorization header is required


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner January 16, 2025 17:55
Copy link

netlify bot commented Jan 16, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit b84a30d
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/6789480a584516000809332c
😎 Deploy Preview https://deploy-preview-12713--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 16, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit b84a30d
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6789480a5d211300086b558c

Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-b84a30def633f796fbf27b7af9dab50c9999a480
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-b84a30def633f796fbf27b7af9dab50c9999a480-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-b84a30def633f796fbf27b7af9dab50c9999a480

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-b84a30def633f796fbf27b7af9dab50c9999a480-arm64

Afterwards, run the upgrade commands from the latest release notes.

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.77%. Comparing base (f354574) to head (b84a30d).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12713      +/-   ##
==========================================
+ Coverage   92.70%   92.77%   +0.06%     
==========================================
  Files         769      769              
  Lines       38898    38898              
==========================================
+ Hits        36059    36086      +27     
+ Misses       2839     2812      -27     
Flag Coverage Δ
e2e 48.58% <ø> (+0.09%) ⬆️
integration 24.62% <ø> (ø)
unit 90.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit 4597ee4 into main Jan 16, 2025
67 of 69 checks passed
@BeryJu BeryJu deleted the sources/oauth/include-basic-auth branch January 16, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OAuth/OIDC Source: Basic Auth Headers (potential fix)
1 participant