core: Tidy contributor onboarding, fix typos. #12700
Open
+111
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12700 +/- ##
==========================================
+ Coverage 92.75% 92.77% +0.02%
==========================================
Files 769 769
Lines 38929 38929
==========================================
+ Hits 36108 36116 +8
+ Misses 2821 2813 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rissson
requested changes
Jan 16, 2025
GirlBossRush
force-pushed
the
onboarding-revisions-v1
branch
from
fe330fd to
10893ee
Compare
GirlBossRush
commented
Jan 16, 2025
rissson
requested changes
Jan 20, 2025
rissson
reviewed
Jan 20, 2025
tanberry
reviewed
Jan 27, 2025
GirlBossRush
force-pushed
the
onboarding-revisions-v1
branch
from
f69153f to
1f6466d
Compare
rissson
requested changes
Jan 29, 2025
| @@ -134,7 +134,7 @@ module.exports = async function (): Promise<Config> { | |||
| docsPluginId: "docs", | |||
| config: { | |||
| authentik: { | |||
| specPath: "static/schema.yaml", | |||
| specPath: "static/schema.yml", | |||
There was a problem hiding this comment.
We should add a redirect for this in the netlify.toml
- Fixes typos. - Fixes stale links. - Tidies Makefile so that Poetry env is optional for hygiene commands. - Remove mismatched YAML naming. - Uses shebang on Python scripts. - Document semver usage. - Redirect OpenAPI schema.
GirlBossRush
force-pushed
the
onboarding-revisions-v1
branch
from
1f6466d to
908679d
Compare
rissson
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR contains a subset of fixes discovered when progressing through the authentik contributor guide. Highlights include:
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make website)