Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/integrations: Add troubleshooting part to Synology guide #12681

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

CFenner
Copy link
Contributor

@CFenner CFenner commented Jan 15, 2025

Details

When the Synology sso pup-up is blocked by the browser (Safari), the login will fail.


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Christopher Fenner <9592452+CFenner@users.noreply.github.com>
@CFenner CFenner requested a review from a team as a code owner January 15, 2025 10:10
Copy link

netlify bot commented Jan 15, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit ba02b4e
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/67932426243cd60008b9e6c9
😎 Deploy Preview https://deploy-preview-12681--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 15, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit ba02b4e
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6793242689e89c000839f31a

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.70%. Comparing base (463efac) to head (ba02b4e).
Report is 55 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12681      +/-   ##
==========================================
- Coverage   92.75%   92.70%   -0.05%     
==========================================
  Files         769      769              
  Lines       38884    38911      +27     
==========================================
+ Hits        36067    36074       +7     
- Misses       2817     2837      +20     
Flag Coverage Δ
e2e 48.48% <ø> (-0.10%) ⬇️
integration 24.62% <ø> (-0.02%) ⬇️
unit 90.40% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for adding this tip, @CFenner! A few nits, please, and then let's merge!

Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: Christopher Fenner <9592452+CFenner@users.noreply.github.com>
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: Christopher Fenner <9592452+CFenner@users.noreply.github.com>
Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @CFenner !!

@tanberry tanberry merged commit f245dad into goauthentik:main Jan 24, 2025
67 of 69 checks passed
@CFenner CFenner deleted the patch-3 branch January 24, 2025 14:14
kensternberg-authentik added a commit that referenced this pull request Jan 27, 2025
* main: (26 commits)
  website: bump docusaurus-plugin-openapi-docs from 4.3.1 to 4.3.2 in /website (#12844)
  core: bump aws-cdk-lib from 2.176.0 to 2.177.0 (#12842)
  lifecycle/aws: bump aws-cdk from 2.176.0 to 2.177.0 in /lifecycle/aws (#12845)
  web: Fix issue where Codemirror partially applies OneDark theme. (#12811)
  ci: fix container build always attempting to push (#12810)
  lifecycle: better pre release test (#12806)
  rbac: exclude permissions for internal models (#12803)
  web: bump store2 from 2.14.3 to 2.14.4 in /web (#12805)
  website: integrations-all: update doc titles to start with "integrate with" (#12775)
  web/flows: fix `login` / `log in` inconsistency (#12526)
  flows: clear flow state before redirecting to final URL (#12788)
  core: bump goauthentik.io/api/v3 from 3.2024122.2 to 3.2024122.3 (#12793)
  core: bump kubernetes from 31.0.0 to 32.0.0 (#12794)
  core: bump pydantic from 2.10.5 to 2.10.6 (#12795)
  core: bump msgraph-sdk from 1.17.0 to 1.18.0 (#12796)
  core: bump selenium from 4.28.0 to 4.28.1 (#12797)
  core: bump ruff from 0.9.2 to 0.9.3 (#12798)
  website/integrations: Add troubleshooting part to Synology guide (#12681)
  core: fix permissions for admin device listing (#12787)
  website/docs: Flesh out Google Workspaces SAML. (#12701)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants