Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

website/integrations: gitlab to have binding in saml section be post #12677

Merged
merged 1 commit into from
Jan 30, 2025
Merged

website/integrations: gitlab to have binding in saml section be post #12677

merged 1 commit into from
Jan 30, 2025

Conversation

ncamacho
Copy link
Contributor

After upgrading to version 2024.12.2 SAML stopped working in gitlab and was causing 502 errors. After some troubleshooting I finally got it to work again by changing binding to "Post" instead of the recommended "Redirect" in this howto.

Details

REPLACE ME

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@ncamacho
Update index.md to have binding in saml section be post
bbc8775 
After upgrading to version 2024.12.2 SAML stopped working in gitlab and was causing 502 errors. After some troubleshooting I finally got it to work again by changing binding to "Post" instead of the recommended "Redirect" in this howto.  

Signed-off-by: Nestor N. Camacho III <ncamacho@gmail.com>
@ncamacho ncamacho requested a review from a team as a code owner January 14, 2025 23:57
@netlify Netlify
Copy link

netlify bot commented Jan 14, 2025 •
edited
Loading

✅ Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit bbc8775
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/6786f9e4c42d0600083d8cbe
😎 Deploy Preview https://deploy-preview-12677--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ncamacho
Copy link
Contributor Author

After upgrading to version 2024.12.2 SAML stopped working in gitlab and was causing 502 errors. After some troubleshooting I finally got it to work again by changing binding to "Post" instead of the recommended "Redirect" in this howto.

@netlify Netlify
Copy link

netlify bot commented Jan 14, 2025 •
edited
Loading

✅ Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit bbc8775
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6786f9e4bfd35100082b4f42

@tanberry tanberry changed the title Update index.md to have binding in saml section be post website/integrations: Update index.md to have binding in saml section be post Jan 15, 2025
@tanberry
Copy link
Contributor

Thank you so much @ncamacho for this PR; we will have a quick look at why Redirect was failing, and see if we need to add more info to the docs.

@tanberry tanberry added the status/reviewing thanks for opening, we're taking a look label Jan 15, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.67%. Comparing base (f450865) to head (bbc8775).
Report is 99 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #12677      +/-   ##
==========================================
- Coverage   92.71%   91.67%   -1.05%     
==========================================
  Files         769      769              
  Lines       38884    38884              
==========================================
- Hits        36052    35646     -406     
- Misses       2832     3238     +406
Flag Coverage Δ
e2e 48.63% <ø> (+0.07%) ⬆️
integration ?
unit 90.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ncamacho
Copy link
Contributor Author

ncamacho commented Jan 15, 2025 via email

@BeryJu
Copy link
Member

BeryJu commented Jan 16, 2025

@ncamacho do you have both sign assertions and sign responses enabled in the SAML provider?

@ncamacho
Copy link
Contributor Author

ncamacho commented Jan 21, 2025 via email

@tanberry
Copy link
Contributor

Yes, I do. [image: image.png] Nes++
…
On Thu, Jan 16, 2025 at 10:09 AM Jens L. @.> wrote: @ncamacho https://github.com/ncamacho do you have both sign assertions and sign responses enabled in the SAML provider? — Reply to this email directly, view it on GitHub <#12677 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABWWFDDNTZOQ3LTHNXRBJ32K7YXNAVCNFSM6AAAAABVGARMW2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJWGM4DMOJVGA . You are receiving this because you were mentioned.Message ID: @.>

Thanks for letting us know @ncamacho . I think we need to add more context around this... not specify one or the other setting, because it seems that both might work in diff situations?

@ncamacho
Copy link
Contributor Author

ncamacho commented Jan 22, 2025 via email

@tanberry
Copy link
Contributor

Are you saying, that if I were to disable those two and put it back to "Redirect" it would work? Nes++ On Wed, Jan 22, 2025 at 8:49 AM Tana M Berry @.> wrote:
…
Yes, I do. [image: image.png] Nes++ … <#m_3744106224942584800_> On Thu, Jan 16, 2025 at 10:09 AM Jens L. @.> wrote: @ncamacho https://github.com/ncamacho https://github.com/ncamacho https://github.com/ncamacho do you have both sign assertions and sign responses enabled in the SAML provider? — Reply to this email directly, view it on GitHub <#12677 (comment) <#12677 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABWWFDDNTZOQ3LTHNXRBJ32K7YXNAVCNFSM6AAAAABVGARMW2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJWGM4DMOJVGA https://github.com/notifications/unsubscribe-auth/AABWWFDDNTZOQ3LTHNXRBJ32K7YXNAVCNFSM6AAAAABVGARMW2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJWGM4DMOJVGA . You are receiving this because you were mentioned.Message ID: @.> Thanks for letting us know @ncamacho https://github.com/ncamacho . I think we need to add more context around this... not specify one or the other setting, because it seems that both might work in diff situations? — Reply to this email directly, view it on GitHub <#12677 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABWWFAWHNKIS6GQRKI3UG32L7DX3AVCNFSM6AAAAABVGARMW2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBXG42TKMJUGM . You are receiving this because you were mentioned.Message ID: @.**>

I'll need @BeryJu to answer this one. ;-)

@ncamacho
Copy link
Contributor Author

ncamacho commented Jan 26, 2025 via email

@BeryJu BeryJu changed the title website/integrations: Update index.md to have binding in saml section be post website/integrations: gitlab to have binding in saml section be post Jan 30, 2025
@BeryJu BeryJu merged commit 427a8c9 into goauthentik:main Jan 30, 2025
65 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status/reviewing thanks for opening, we're taking a look
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncamacho @tanberry @BeryJu