Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/integrations: Update Semaphore UI description #12674

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

CFenner
Copy link
Contributor

@CFenner CFenner commented Jan 14, 2025

Details

I had issues when getting authentik to work with semaphore in a docker compose scenario. It turned out that it helps to set the SEMAPHORE_WEB_ROOT env var in this case.


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Christopher Fenner <9592452+CFenner@users.noreply.github.com>
@CFenner CFenner requested a review from a team as a code owner January 14, 2025 21:54
Copy link

netlify bot commented Jan 14, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 09a868d
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/67880e9f83fced0008c35c60
😎 Deploy Preview https://deploy-preview-12674--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 14, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 09a868d
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/67880e9fac57d700084e4015

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.75%. Comparing base (336f6f0) to head (09a868d).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12674      +/-   ##
==========================================
- Coverage   92.76%   92.75%   -0.02%     
==========================================
  Files         769      769              
  Lines       38884    38886       +2     
==========================================
- Hits        36072    36069       -3     
- Misses       2812     2817       +5     
Flag Coverage Δ
e2e 48.58% <ø> (-0.02%) ⬇️
integration 24.63% <ø> (-0.01%) ⬇️
unit 90.39% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: Christopher Fenner <9592452+CFenner@users.noreply.github.com>
@CFenner CFenner changed the title Update Semaphore UI description website/integrations: Update Semaphore UI description Jan 15, 2025
Signed-off-by: Christopher Fenner <9592452+CFenner@users.noreply.github.com>
@tanberry
Copy link
Contributor

Hi @CFenner thanks for your further work... the build check called lint (prettier-check) is failing... can you run make website locally please, and then push again to this PR? That command runs our formatting tool, and we need the build check to pass before we can merge. Let me know if you prefer that I do it, no worries!

Also, just fyi, we will eventually be replacing the sections about using the Wizard in all of the integration guides, with more detailed info about accessing the Wizard. What you have is fine for now, though.

@tanberry tanberry added the status/awaiting-contributor Awaiting a response from the contributor label Jan 15, 2025
@CFenner
Copy link
Contributor Author

CFenner commented Jan 15, 2025

@tanberry npm run prettier --prefix website is without findings. However I cannot run make website as there are multiple other tools missing in my setup.
If you don't mind to check this out, I would be thankful. I think I got it now..

Signed-off-by: Christopher Fenner <9592452+CFenner@users.noreply.github.com>
Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again so much @CFenner , and for rerunning the linting/formatting tools. LGTM!

@tanberry tanberry merged commit 661a966 into goauthentik:main Jan 16, 2025
65 of 67 checks passed
@CFenner CFenner deleted the patch-2 branch January 16, 2025 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/awaiting-contributor Awaiting a response from the contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants