Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providers/saml: fix invalid SAML Response when assertion and response are signed #12611

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Jan 9, 2025

Details

closes #12306


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

… are signed

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner January 9, 2025 14:21
Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 423db43
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/677fe08fc46d770008258b37
😎 Deploy Preview https://deploy-preview-12611--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 423db43
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/677fe08e2feba70008d66be0

@BeryJu
Copy link
Member Author

BeryJu commented Jan 9, 2025

/cherry-pick version-2024.12

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.75%. Comparing base (9d15fa4) to head (423db43).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12611      +/-   ##
==========================================
- Coverage   92.76%   92.75%   -0.01%     
==========================================
  Files         769      769              
  Lines       38828    38840      +12     
==========================================
+ Hits        36017    36026       +9     
- Misses       2811     2814       +3     
Flag Coverage Δ
e2e 48.58% <15.38%> (-0.07%) ⬇️
integration 24.63% <0.00%> (-0.01%) ⬇️
unit 90.39% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Copy link
Contributor

github-actions bot commented Jan 9, 2025

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-423db43052846b81c1024d80146ce49036074e5d
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-423db43052846b81c1024d80146ce49036074e5d-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-423db43052846b81c1024d80146ce49036074e5d

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-423db43052846b81c1024d80146ce49036074e5d-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit 774a84f into main Jan 9, 2025
65 of 67 checks passed
@BeryJu BeryJu deleted the providers/saml/fix-double-sign branch January 9, 2025 15:20
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jan 9, 2025
… are signed (#12611)

* providers/saml: fix invalid SAML Response when assertion and response are signed

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* validate against schema too

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
BeryJu added a commit that referenced this pull request Jan 9, 2025
… are signed (cherry-pick #12611) (#12613)

providers/saml: fix invalid SAML Response when assertion and response are signed (#12611)

* providers/saml: fix invalid SAML Response when assertion and response are signed



* validate against schema too



---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Co-authored-by: Jens L. <jens@goauthentik.io>
kensternberg-authentik added a commit that referenced this pull request Jan 11, 2025
* main:
  website: revise full development environment instructions (#12638)
  website: bump typescript from 5.7.2 to 5.7.3 in /website (#12620)
  website: bump aws-cdk from 2.174.1 to 2.175.0 in /website (#12621)
  ci: bump docker/setup-qemu-action from 3.2.0 to 3.3.0 (#12622)
  core: bump twilio from 9.4.1 to 9.4.2 (#12623)
  core: bump python-kadmin-rs from 0.5.2 to 0.5.3 (#12624)
  core: bump ruff from 0.8.6 to 0.9.0 (#12625)
  core: bump pydantic from 2.10.4 to 2.10.5 (#12626)
  core: bump google-api-python-client from 2.157.0 to 2.158.0 (#12628)
  core: bump goauthentik.io/api/v3 from 3.2024121.3 to 3.2024122.1 (#12629)
  web: bump API Client version (#12617)
  release: 2024.12.2 (#12615)
  website/docs: prepare 2024.12.2 release notes (#12614)
  providers/saml: fix invalid SAML Response when assertion and response are signed (#12611)
  core: fix error when creating new user with default path (#12609)
  rbac: permissions endpoint: allow authenticated users (#12608)
  website/docs: update customer portal (#12603)
  website/docs: policy for email whitelist: modernize (#12558)
mahmoudajawad pushed a commit to mahmoudajawad/authentik that referenced this pull request Jan 15, 2025
… are signed (goauthentik#12611)

* providers/saml: fix invalid SAML Response when assertion and response are signed

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* validate against schema too

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SAML Provider: Unable to sign both assertions and response.
1 participant