Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/integrations: owncloud: document #12540

Merged

Conversation

dominic-r
Copy link
Contributor

sdko/feat/integration/pickup-10943-owncloud

Closes #10943

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Apply changes from old MR
Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 036259c
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6799394892bb1f0008f107f7

Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 036259c
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/6799394892ca8500080fdf53
😎 Deploy Preview https://deploy-preview-12540--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Some easy fixes to match template
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.75%. Comparing base (5109af0) to head (036259c).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12540   +/-   ##
=======================================
  Coverage   92.75%   92.75%           
=======================================
  Files         769      769           
  Lines       38926    38929    +3     
=======================================
+ Hits        36106    36110    +4     
+ Misses       2820     2819    -1     
Flag Coverage Δ
e2e 48.57% <ø> (+<0.01%) ⬆️
integration 24.60% <ø> (+<0.01%) ⬆️
unit 90.40% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dominic-r
Copy link
Contributor Author

Thanks for this review Tana. Didn't have a chance to finish cleaning the PR up after merging the old changes

4d62 added 11 commits January 3, 2025 02:05
Cleans up the authentik configuration section of this documentation and removes unneeded bits
Add `### Configuration` header and switch General Settings, Protocl Settings, and Advanced Protocol Settings to H4
…move unneeded block


Updates the service discovery block to be more in-line with documentation, renames "Apache" to "Apache HTTPD" (correct name), removes provider specific documentation for traefik and instead tells users to view provider-specific docs.

Also removes section kept last commit
…ion" section


Starts cleaning up the steps, adds warning for sub and the other one, grammar, styling and bla bla bla
Adds single quotes for client-id and client-secret lines. Should be fine I think. Logic says quotes but old docs had none
Cleanup the rest of the ownCloud section and update the loginButtonName variable
Lints the code with Prettier
@dominic-r dominic-r marked this pull request as ready for review January 5, 2025 19:25
@dominic-r dominic-r requested a review from a team as a code owner January 5, 2025 19:25
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: 4d62 <git@sdko.org>

- **Configure Bindings** (optional): To manage the listing and access to applications on a user's **My applications** page, you can optionally create a [binding](https://docs.goauthentik.io/docs/add-secure-apps/flows-stages/bindings/) between the application and a specific policy, group, or user. Keep in mind that if you do not specify any bindings, all users will have access to the application. For more information about user access, refer to our documentation about [authorization](https://docs.goauthentik.io/docs/add-secure-apps/applications/manage_apps#policy-driven-authorization) and [hiding an application](https://docs.goauthentik.io/docs/add-secure-apps/applications/manage_apps#hide-applications).

### Service discovery
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a more descriptive title? Also... can we specify that it is is the reverse proxy is configured within authentik? Should that be one of the regular steps in the "authentik configuration" section?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the reverse-proxy is not within authentik or the service. I can rename the title if you want but it should have it's own section IMO. Tho, it's technically the config to make it work with the service. As you wish

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One can configure a reverse proxy within authentik (@BeryJu ??), but if for sure this one is not configured there, then let's leave as is.


To enable OIDC functionality in ownCloud, follow these steps:

1. **Navigate to the Market**:
Copy link
Contributor

@tanberry tanberry Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I can google correctly, Market is the app used to access Marketplace... do we want to say Market or Marketplace here? https://marketplace.owncloud.com/

@dominic-r dominic-r requested a review from tanberry January 27, 2025 20:12
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: 4d62 <git@sdko.org>
Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @4d62 for this PR, and thank you also @rickyelopez for the original PR!

@tanberry tanberry merged commit 06d57a7 into goauthentik:main Jan 28, 2025
69 checks passed
@dominic-r dominic-r deleted the sdko/feat/integration/pickup-10943-owncloud branch January 28, 2025 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants