Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sources/kerberos: add kadmin type setting, provide additional context to property mappings #12286

Merged
merged 8 commits into from
Dec 12, 2024

Conversation

rissson
Copy link
Member

@rissson rissson commented Dec 6, 2024

Details


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

… to property mappings

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@rissson rissson self-assigned this Dec 6, 2024
Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 5117afe
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/67572d8caf11130008fddc6c
😎 Deploy Preview https://deploy-preview-12286--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 5117afe
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/67572d8cbb38500008eb0acd
😎 Deploy Preview https://deploy-preview-12286--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.67%. Comparing base (28a2311) to head (5117afe).
Report is 21 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
authentik/sources/kerberos/models.py 85.71% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12286      +/-   ##
==========================================
- Coverage   92.68%   92.67%   -0.01%     
==========================================
  Files         762      762              
  Lines       38156    38170      +14     
==========================================
+ Hits        35363    35375      +12     
- Misses       2793     2795       +2     
Flag Coverage Δ
e2e 49.08% <35.29%> (-0.01%) ⬇️
integration 24.76% <35.29%> (+<0.01%) ⬆️
unit 90.21% <88.23%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Copy link
Contributor

github-actions bot commented Dec 6, 2024

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-5117afee93603e856fe47ba40d8c3e158974c643
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-5117afee93603e856fe47ba40d8c3e158974c643-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-5117afee93603e856fe47ba40d8c3e158974c643

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-5117afee93603e856fe47ba40d8c3e158974c643-arm64

Afterwards, run the upgrade commands from the latest release notes.

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@rissson rissson marked this pull request as ready for review December 7, 2024 03:22
@rissson rissson requested review from a team as code owners December 7, 2024 03:22
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, to add a noun for what exactly is being invoked, but otherwise LGTM!

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@rissson rissson enabled auto-merge (squash) December 9, 2024 18:42
@rissson rissson merged commit deacc17 into main Dec 12, 2024
70 of 71 checks passed
@rissson rissson deleted the kerberos-extra-data branch December 12, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants