Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: backport fix impersonate api #12184

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Nov 25, 2024

Details

unintended client API change slipped in due to API changes in CVE fix

closes #12163


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner November 25, 2024 15:49
Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 7b88a0b
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/67449c8b1134720008f474f0
😎 Deploy Preview https://deploy-preview-12184--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.60%. Comparing base (d9fbe1d) to head (7b88a0b).
Report is 1 commits behind head on version-2024.10.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           version-2024.10   #12184      +/-   ##
===================================================
- Coverage            92.67%   92.60%   -0.07%     
===================================================
  Files                  761      761              
  Lines                37953    37953              
===================================================
- Hits                 35172    35147      -25     
- Misses                2781     2806      +25     
Flag Coverage Δ
e2e 49.17% <ø> (-0.11%) ⬇️
integration 24.87% <ø> (ø)
unit 90.19% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu
Copy link
Member Author

BeryJu commented Nov 25, 2024

/cherry-pick version-2024.8

@BeryJu BeryJu changed the title web/backport fix impersonate api web: backport fix impersonate api Nov 25, 2024
@BeryJu BeryJu enabled auto-merge (squash) November 25, 2024 16:04
@BeryJu BeryJu disabled auto-merge November 25, 2024 16:04
@BeryJu BeryJu merged commit efac5ce into version-2024.10 Nov 25, 2024
52 of 54 checks passed
@BeryJu BeryJu deleted the web/backport-fix-impersonate-api branch November 25, 2024 16:04
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Nov 25, 2024
web/admin: fix impersonate API call

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
BeryJu added a commit that referenced this pull request Nov 25, 2024
web: backport fix impersonate api (#12184)

web/admin: fix impersonate API call

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Co-authored-by: Jens L. <jens@goauthentik.io>
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-7b88a0ba662a05076ee209f4b21caf9bed972b6a
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-7b88a0ba662a05076ee209f4b21caf9bed972b6a-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-7b88a0ba662a05076ee209f4b21caf9bed972b6a

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-7b88a0ba662a05076ee209f4b21caf9bed972b6a-arm64

Afterwards, run the upgrade commands from the latest release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant