Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/integrations: added hoarder integration #12161

Merged
merged 22 commits into from
Dec 17, 2024

Conversation

shelldandy
Copy link
Contributor

@shelldandy shelldandy commented Nov 22, 2024

Details

Added Hoarder Integration to docs.

@shelldandy shelldandy requested a review from a team as a code owner November 22, 2024 17:30
Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 573e04f
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/67619d65af2b6000082b1f20
😎 Deploy Preview https://deploy-preview-12161--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 573e04f
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/67619d6527ecd900083f1383
😎 Deploy Preview https://deploy-preview-12161--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@dominic-r dominic-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments. Let me know if you have any questions.

website/integrations/services/hoarder/index.md Outdated Show resolved Hide resolved
website/integrations/services/hoarder/index.md Outdated Show resolved Hide resolved
website/sidebarsIntegrations.js Outdated Show resolved Hide resolved
website/integrations/services/hoarder/index.md Outdated Show resolved Hide resolved
website/integrations/services/hoarder/index.md Outdated Show resolved Hide resolved
website/integrations/services/hoarder/index.md Outdated Show resolved Hide resolved
website/integrations/services/hoarder/index.md Outdated Show resolved Hide resolved
website/integrations/services/hoarder/index.md Outdated Show resolved Hide resolved
website/integrations/services/hoarder/index.md Outdated Show resolved Hide resolved
website/integrations/services/hoarder/index.md Outdated Show resolved Hide resolved
shelldandy and others added 10 commits November 24, 2024 16:28
Co-authored-by: 4d62 <github-user@sdko.org>
Signed-off-by: Miguel Palau <mpalauzarza@gmail.com>
Co-authored-by: 4d62 <github-user@sdko.org>
Signed-off-by: Miguel Palau <mpalauzarza@gmail.com>
Co-authored-by: 4d62 <github-user@sdko.org>
Signed-off-by: Miguel Palau <mpalauzarza@gmail.com>
Co-authored-by: 4d62 <github-user@sdko.org>
Signed-off-by: Miguel Palau <mpalauzarza@gmail.com>
Co-authored-by: 4d62 <github-user@sdko.org>
Signed-off-by: Miguel Palau <mpalauzarza@gmail.com>
Co-authored-by: 4d62 <github-user@sdko.org>
Signed-off-by: Miguel Palau <mpalauzarza@gmail.com>
Co-authored-by: 4d62 <github-user@sdko.org>
Signed-off-by: Miguel Palau <mpalauzarza@gmail.com>
Co-authored-by: 4d62 <github-user@sdko.org>
Signed-off-by: Miguel Palau <mpalauzarza@gmail.com>
@shelldandy shelldandy requested a review from dominic-r November 24, 2024 22:37
@shelldandy
Copy link
Contributor Author

@4d62 just addressed the comments and commited the suggestions, lmk if more tweaks are needed

Copy link
Contributor

@dominic-r dominic-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your response & corrections. It looks good, but I noticed a few more things that can be changed to make it perfect.

cc @tanberry for final review

website/integrations/services/hoarder/index.md Outdated Show resolved Hide resolved
website/integrations/services/hoarder/index.md Outdated Show resolved Hide resolved
website/integrations/services/hoarder/index.md Outdated Show resolved Hide resolved
website/integrations/services/hoarder/index.md Outdated Show resolved Hide resolved
website/integrations/services/hoarder/index.md Outdated Show resolved Hide resolved
shelldandy and others added 5 commits November 24, 2024 21:48
Co-authored-by: 4d62 <github-user@sdko.org>
Signed-off-by: Miguel Palau <mpalauzarza@gmail.com>
Co-authored-by: 4d62 <github-user@sdko.org>
Signed-off-by: Miguel Palau <mpalauzarza@gmail.com>
Co-authored-by: 4d62 <github-user@sdko.org>
Signed-off-by: Miguel Palau <mpalauzarza@gmail.com>
Co-authored-by: 4d62 <github-user@sdko.org>
Signed-off-by: Miguel Palau <mpalauzarza@gmail.com>
Co-authored-by: 4d62 <github-user@sdko.org>
Signed-off-by: Miguel Palau <mpalauzarza@gmail.com>
@shelldandy
Copy link
Contributor Author

@4d62 comments addressed lmk if more changes are needed

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.69%. Comparing base (0527951) to head (573e04f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12161      +/-   ##
==========================================
- Coverage   92.76%   92.69%   -0.08%     
==========================================
  Files         767      767              
  Lines       38522    38522              
==========================================
- Hits        35736    35707      -29     
- Misses       2786     2815      +29     
Flag Coverage Δ
e2e 48.75% <ø> (-0.16%) ⬇️
integration 24.69% <ø> (ø)
unit 90.32% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tanberry
Copy link
Contributor

tanberry commented Dec 3, 2024

Thanks so much @shelldandy for this addition to our Integrations docs! (And thanks @4d62 for your edits, much appreciated.)

I made a few edits based on our title capitalization style; we use sentence case for titles, and the product name authentik is with a lower-case "a". Here's a link to our Style Guide for more info about titles and other things. https://docs.goauthentik.io/docs/developer-docs/docs/style-guide

Thanks again! Once you get those few edits made, let's merge!

Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: Miguel Palau <mpalauzarza@gmail.com>
shelldandy and others added 2 commits December 3, 2024 17:14
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: Miguel Palau <mpalauzarza@gmail.com>
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: Miguel Palau <mpalauzarza@gmail.com>
@shelldandy
Copy link
Contributor Author

@4d62 @tanberry comments addressed!

Copy link
Contributor

@dominic-r dominic-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. thanks for your contribution!

@dominic-r
Copy link
Contributor

cc @tanberry for merge

@shelldandy shelldandy requested a review from dominic-r December 8, 2024 23:35
@shelldandy
Copy link
Contributor Author

@tanberry can we merge now?

@tanberry
Copy link
Contributor

@tanberry can we merge now?

Hi @shelldandy thanks for your patience with this... the authentik-ci-website / lint (prettier-check) build check is still failing. I pulled to your PR locally, ran make website, but seem unable to push it back to your PR... I can get some help from the dev team tomorrow, or if you want to try to resolve this you can run these commands, then push again:

make website-install (run this to update your local build tools, we recently bumped up a version)
make website

Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for this contribution, @shelldandy !

@tanberry tanberry merged commit 559ec29 into goauthentik:main Dec 17, 2024
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants