-
-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
website/integrations: added hoarder integration #12161
website/integrations: added hoarder integration #12161
Conversation
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments. Let me know if you have any questions.
Co-authored-by: 4d62 <github-user@sdko.org> Signed-off-by: Miguel Palau <mpalauzarza@gmail.com>
Co-authored-by: 4d62 <github-user@sdko.org> Signed-off-by: Miguel Palau <mpalauzarza@gmail.com>
Co-authored-by: 4d62 <github-user@sdko.org> Signed-off-by: Miguel Palau <mpalauzarza@gmail.com>
Co-authored-by: 4d62 <github-user@sdko.org> Signed-off-by: Miguel Palau <mpalauzarza@gmail.com>
Co-authored-by: 4d62 <github-user@sdko.org> Signed-off-by: Miguel Palau <mpalauzarza@gmail.com>
Co-authored-by: 4d62 <github-user@sdko.org> Signed-off-by: Miguel Palau <mpalauzarza@gmail.com>
Co-authored-by: 4d62 <github-user@sdko.org> Signed-off-by: Miguel Palau <mpalauzarza@gmail.com>
Co-authored-by: 4d62 <github-user@sdko.org> Signed-off-by: Miguel Palau <mpalauzarza@gmail.com>
@4d62 just addressed the comments and commited the suggestions, lmk if more tweaks are needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for your response & corrections. It looks good, but I noticed a few more things that can be changed to make it perfect.
cc @tanberry for final review
Co-authored-by: 4d62 <github-user@sdko.org> Signed-off-by: Miguel Palau <mpalauzarza@gmail.com>
Co-authored-by: 4d62 <github-user@sdko.org> Signed-off-by: Miguel Palau <mpalauzarza@gmail.com>
Co-authored-by: 4d62 <github-user@sdko.org> Signed-off-by: Miguel Palau <mpalauzarza@gmail.com>
Co-authored-by: 4d62 <github-user@sdko.org> Signed-off-by: Miguel Palau <mpalauzarza@gmail.com>
Co-authored-by: 4d62 <github-user@sdko.org> Signed-off-by: Miguel Palau <mpalauzarza@gmail.com>
@4d62 comments addressed lmk if more changes are needed |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12161 +/- ##
==========================================
- Coverage 92.76% 92.69% -0.08%
==========================================
Files 767 767
Lines 38522 38522
==========================================
- Hits 35736 35707 -29
- Misses 2786 2815 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks so much @shelldandy for this addition to our Integrations docs! (And thanks @4d62 for your edits, much appreciated.) I made a few edits based on our title capitalization style; we use sentence case for titles, and the product name authentik is with a lower-case "a". Here's a link to our Style Guide for more info about titles and other things. https://docs.goauthentik.io/docs/developer-docs/docs/style-guide Thanks again! Once you get those few edits made, let's merge! |
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com> Signed-off-by: Miguel Palau <mpalauzarza@gmail.com>
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com> Signed-off-by: Miguel Palau <mpalauzarza@gmail.com>
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com> Signed-off-by: Miguel Palau <mpalauzarza@gmail.com>
@4d62 @tanberry comments addressed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. thanks for your contribution!
cc @tanberry for merge |
@tanberry can we merge now? |
Hi @shelldandy thanks for your patience with this... the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for this contribution, @shelldandy !
Details
Added Hoarder Integration to docs.