sources/ldap: lint changed files

goauthentik · Jan 14, 2025 · a74b15d · a74b15d
1 parent 1211310
commit a74b15d
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 13 deletions.
diff --git a/authentik/sources/ldap/migrations/0007_ldapsource_lookup_groups_from_user.py b/authentik/sources/ldap/migrations/0007_ldapsource_lookup_groups_from_user.py
@@ -6,7 +6,10 @@
 class Migration(migrations.Migration):
 
     dependencies = [
-        ("authentik_sources_ldap", "0006_rename_ldappropertymapping_ldapsourcepropertymapping_and_more"),
+        (
+            "authentik_sources_ldap",
+            "0006_rename_ldappropertymapping_ldapsourcepropertymapping_and_more",
+        ),
     ]
 
     operations = [

diff --git a/authentik/sources/ldap/models.py b/authentik/sources/ldap/models.py
@@ -126,11 +126,9 @@ class LDAPSource(Source):
     lookup_groups_from_user = models.BooleanField(
         default=False,
         help_text=_(
-            (
-                "Lookup group membership based on a user attribute instead of a group attribute."
-                "This allows nested group resolution on systems like FreeIPA and Active Directory"
-            )
-        )
+            "Lookup group membership based on a user attribute instead of a group attribute."
+            "This allows nested group resolution on systems like FreeIPA and Active Directory"
+        ),
     )
 
     @property

diff --git a/authentik/sources/ldap/sync/membership.py b/authentik/sources/ldap/sync/membership.py
@@ -28,11 +28,12 @@ def get_objects(self, **kwargs) -> Generator:
         if not self._source.sync_groups:
             self.message("Group syncing is disabled for this Source")
             return iter(())
-
+
+        # If we are looking up groups from users, we don't need to fetch the group membership field
         attributes = [self._source.object_uniqueness_field, LDAP_DISTINGUISHED_NAME]
-        if not self._source.lookup_groups_from_user:  # If we are looking up groups from users, we don't need to fetch the group membership field
+        if not self._source.lookup_groups_from_user:
             attributes.append(self._source.group_membership_field)
-        
+
         return self.search_paginator(
             search_base=self.base_dn_groups,
             search_filter=self._source.group_object_filter,
@@ -55,9 +56,7 @@ def sync(self, page_data: list) -> int:
                     search_base=self.base_dn_users,
                     search_filter=group_filter,
                     search_scope=SUBTREE,
-                    attributes=[
-                        self._source.object_uniqueness_field
-                    ]
+                    attributes=[self._source.object_uniqueness_field],
                 )
                 members = []
                 for group_member in group_members:

diff --git a/web/src/admin/sources/ldap/LDAPSourceForm.ts b/web/src/admin/sources/ldap/LDAPSourceForm.ts
@@ -428,7 +428,9 @@ export class LDAPSourceForm extends BaseSourceForm<LDAPSource> {
                                     <i class="fas fa-check" aria-hidden="true"></i>
                                 </span>
                             </span>
-                            <span class="pf-c-switch__label">${msg("Lookup using user attribute")}</span>
+                            <span class="pf-c-switch__label"
+                                >${msg("Lookup using user attribute")}</span
+                            >
                         </label>
                         <p class="pf-c-form__helper-text">
                             ${msg(