Fixes to WFS (external service) file upload endpoint, require street network layer project ID in catchment area request #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majkshkurti
reviewed
Sep 2, 2024
src/schemas/catchment_area.py
Outdated
Comment on lines
282
to
291
| street_network_edge_layer_project_id: int = Field( | ||
| ..., | ||
| title="Street Network Edge Layer Project ID", | ||
| description="The layer project ID of the street network edge layer.", | ||
| ) | ||
| street_network_node_layer_project_id: int = Field( | ||
| settings.STREET_NETWORK_NODE_DEFAULT_LAYER_PROJECT_ID, | ||
| title="Street Network Node Layer Project ID", | ||
| description="The layer project ID of the street network node layer.", | ||
| ) |
There was a problem hiding this comment.
I think we can make the street_network_edge_layer_project_id and street_network_node_layer_project_id optional here and hardcode it in the api for now. As the network id can be a bit confusing for api usage without the ui.
There was a problem hiding this comment.
Sure, will make this change. But it'll need a dynamic street_network_edge_layer_project_id whenever a network scenario is applied.
There was a problem hiding this comment.
Yes, this I can pass in the client.
majkshkurti
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.