Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add handler type for photo captions #138

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

davidramiro
Copy link
Contributor

@davidramiro davidramiro commented Dec 22, 2024

With incoming messages that come with a photo, HandlerTypeMessageText does not catch those as they are within Update.Message.Caption and not Text.

I initially thought about adding a check for Caption if Text is empty in the HandlerTypeMessageText case, but I think a separate type is cleaner. Let me know what you think!

@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 49.85%. Comparing base (dda4073) to head (1e46f61).

Files with missing lines Patch % Lines
options.go 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
- Coverage   49.90%   49.85%   -0.05%     
==========================================
  Files          26       26              
  Lines        2090     2096       +6     
==========================================
+ Hits         1043     1045       +2     
- Misses       1003     1007       +4     
  Partials       44       44              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@negasus negasus merged commit aac1744 into go-telegram:main Dec 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants