Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: registries groups #75

Merged
merged 11 commits into from
Nov 5, 2024
Merged

feat: registries groups #75

merged 11 commits into from
Nov 5, 2024

Conversation

42atomys
Copy link
Member

@42atomys 42atomys commented Nov 2, 2024

Description

After few feedback on v1.0.0-rc1, a solution for grouping registries and have built-ins groups are requested, this pull request implement the logic of group, keep it simple as possible to prevent add complexity for nothing.

Changes

  • Add AddGroups on Defaulthandler
  • Add WithGroups handler option
  • Add group folder to hold all built-ins group and add two all and hermetic

Resolves #73 #49

Checklist

  • I have read the CONTRIBUTING.md document.
  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation accordingly.
  • This change requires a change to the documentation on the website.

@42atomys 42atomys added priority/low 🟩 Priority 4 - Low priority and doesn't need to be rushed domain/obvious 🟩 Represents the "known knowns" issue. It's Obviously type/feature ⭐ Addition of new feature aspect/dex 🤖 Concerns developers' experience with the codebase aspect/documentation 📚 Improvements or additions to documentation state/done ✔ This is done! labels Nov 2, 2024
@42atomys 42atomys requested a review from a team November 2, 2024 21:54
@42atomys 42atomys self-assigned this Nov 2, 2024
@42atomys 42atomys requested review from ccoVeille and removed request for a team November 2, 2024 21:54
group_test.go Outdated Show resolved Hide resolved
@42atomys 42atomys linked an issue Nov 5, 2024 that may be closed by this pull request
1 task
@42atomys
Copy link
Member Author

42atomys commented Nov 5, 2024

Self review : add a pesticide helper to test a group

@42atomys 42atomys merged commit 692013c into main Nov 5, 2024
15 checks passed
@42atomys 42atomys deleted the feat/registry-group branch November 5, 2024 09:50
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
group.go 100.0% <100.0%> (ø)
group/all/all.go 100.0% <100.0%> (ø)
group/hermetic/hermetic.go 100.0% <100.0%> (ø)
handler.go 100.0% <100.0%> (ø)
pesticide/group_test_helpers.go 100.0% <100.0%> (ø)
pesticide/template_test_helpers.go 100.0% <ø> (ø)

... and 17 files with indirect coverage changes

@ccoVeille
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aspect/dex 🤖 Concerns developers' experience with the codebase aspect/documentation 📚 Improvements or additions to documentation domain/obvious 🟩 Represents the "known knowns" issue. It's Obviously priority/low 🟩 Priority 4 - Low priority and doesn't need to be rushed state/done ✔ This is done! type/feature ⭐ Addition of new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proposal: initialize a handler with all supported registries proposal: Re-add sprout.FuncMap
2 participants