-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: registries groups #75
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42atomys
added
priority/low 🟩
Priority 4 - Low priority and doesn't need to be rushed
domain/obvious 🟩
Represents the "known knowns" issue. It's Obviously
type/feature ⭐
Addition of new feature
aspect/dex 🤖
Concerns developers' experience with the codebase
aspect/documentation 📚
Improvements or additions to documentation
state/done ✔
This is done!
labels
Nov 2, 2024
ccoVeille
approved these changes
Nov 3, 2024
Signed-off-by: Atomys <contact@atomys.fr>
1 task
Self review : add a |
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
aspect/dex 🤖
Concerns developers' experience with the codebase
aspect/documentation 📚
Improvements or additions to documentation
domain/obvious 🟩
Represents the "known knowns" issue. It's Obviously
priority/low 🟩
Priority 4 - Low priority and doesn't need to be rushed
state/done ✔
This is done!
type/feature ⭐
Addition of new feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After few feedback on
v1.0.0-rc1
, a solution for grouping registries and have built-ins groups are requested, this pull request implement the logic of group, keep it simple as possible to prevent add complexity for nothing.Changes
AddGroups
onDefaulthandler
WithGroups
handler optiongroup
folder to hold all built-ins group and add twoall
andhermetic
Resolves #73 #49
Checklist