Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: follow sprout conventions internally #74

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

42atomys
Copy link
Member

@42atomys 42atomys commented Nov 2, 2024

Description

In documentation we ask to have a clear Uid definition but we don't follow this rule inside the sprout package.

Changes

  • Add the organization and repo name in all package UID
  • Turn UID un lowercase (to help future implementation)

Checklist

  • I have read the CONTRIBUTING.md document.
  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation accordingly.
  • This change requires a change to the documentation on the website.

@42atomys 42atomys added type/chore 🛠 Code changes that neither fix bugs nor add features (refactoring, dependency changes, ...) priority/low 🟩 Priority 4 - Low priority and doesn't need to be rushed domain/obvious 🟩 Represents the "known knowns" issue. It's Obviously aspect/documentation 📚 Improvements or additions to documentation state/done ✔ This is done! labels Nov 2, 2024
@42atomys 42atomys requested a review from a team November 2, 2024 21:51
@42atomys 42atomys self-assigned this Nov 2, 2024
@42atomys 42atomys requested review from ccoVeille and removed request for a team November 2, 2024 21:51
registry.go Outdated Show resolved Hide resolved
@42atomys 42atomys merged commit 1c34c3a into main Nov 5, 2024
14 of 15 checks passed
@42atomys 42atomys deleted the chore/respect-rules-in-sprout-uid branch November 5, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aspect/documentation 📚 Improvements or additions to documentation domain/obvious 🟩 Represents the "known knowns" issue. It's Obviously priority/low 🟩 Priority 4 - Low priority and doesn't need to be rushed state/done ✔ This is done! type/chore 🛠 Code changes that neither fix bugs nor add features (refactoring, dependency changes, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants