refactor: move ForceTimeLocal to pesticide

go-sprout · Dec 13, 2024 · a179cb0 · a179cb0
1 parent b961ba1
commit a179cb0
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 17 deletions.
diff --git a/pesticide/time_test_helpers.go b/pesticide/time_test_helpers.go
@@ -0,0 +1,15 @@
+package pesticide
+
+import (
+	"testing"
+	"time"
+)
+
+// ForceTimeLocal temporarily sets [time.Local] for test purpose.
+func ForceTimeLocal(t *testing.T, local *time.Location) {
+	t.Helper()
+
+	originalLocal := time.Local
+	time.Local = local
+	t.Cleanup(func() { time.Local = originalLocal })
+}
diff --git a/registry/conversion/functions_test.go b/registry/conversion/functions_test.go
@@ -9,7 +9,6 @@ import (
 
 	"github.com/go-sprout/sprout/pesticide"
 	"github.com/go-sprout/sprout/registry/conversion"
-	rtime "github.com/go-sprout/sprout/registry/time"
 )
 
 func TestToBool(t *testing.T) {
@@ -137,7 +136,7 @@ func TestToDate(t *testing.T) {
 		require.NoError(t, err)
 
 		// temporarily force time.Local to New York
-		rtime.ForceTimeLocal(t, local)
+		pesticide.ForceTimeLocal(t, local)
 
 		tc := []pesticide.TestCase{
 			{
@@ -177,7 +176,7 @@ func TestToDate(t *testing.T) {
 		require.NoError(t, err)
 
 		// temporarily force time.Local to New York
-		rtime.ForceTimeLocal(t, local)
+		pesticide.ForceTimeLocal(t, local)
 
 		tc := []pesticide.TestCase{
 			{
@@ -206,7 +205,7 @@ func TestToDate(t *testing.T) {
 	t.Run("dates without timezone (local time should be assumed)", func(t *testing.T) {
 		t.Run("UTC", func(t *testing.T) {
 			// temporarily force time.Local to UTC
-			rtime.ForceTimeLocal(t, time.UTC)
+			pesticide.ForceTimeLocal(t, time.UTC)
 
 			tc := []pesticide.TestCase{
 				{
@@ -231,7 +230,7 @@ func TestToDate(t *testing.T) {
 			require.NoError(t, err)
 
 			// temporarily force time.Local to New York
-			rtime.ForceTimeLocal(t, local)
+			pesticide.ForceTimeLocal(t, local)
 
 			tc := []pesticide.TestCase{
 				{

diff --git a/registry/time/functions_test.go b/registry/time/functions_test.go
@@ -64,7 +64,7 @@ func TestDate(t *testing.T) {
 	t.Run("unixtime", func(t *testing.T) {
 		t.Run("UTC", func(t *testing.T) {
 			// temporarily force time.Local to UTC
-			rtime.ForceTimeLocal(t, time.UTC)
+			pesticide.ForceTimeLocal(t, time.UTC)
 
 			// here we are simulating a [gotime.Now]
 			timeTest := time.Date(2024, 5, 7, 15, 4, 5, 0, time.UTC)
@@ -82,7 +82,7 @@ func TestDate(t *testing.T) {
 			require.NoError(t, err)
 
 			// temporarily force time.Local to New York
-			rtime.ForceTimeLocal(t, local)
+			pesticide.ForceTimeLocal(t, local)
 
 			// here we are simulating a [gotime.Now] call
 			timeTest := time.Date(2024, 5, 7, 15, 4, 5, 0, local)

diff --git a/registry/time/helpers.go b/registry/time/helpers.go
@@ -1,7 +1,6 @@
 package time
 
 import (
-	"testing"
 	"time"
 )
 
@@ -23,12 +22,3 @@ func computeTimeFromFormat(date any) time.Time {
 	// otherwise, fallback to the current time
 	return time.Now().Local()
 }
-
-// ForceTimeLocal temporarily sets [time.Local] for test purpose.
-func ForceTimeLocal(t *testing.T, local *time.Location) {
-	t.Helper()
-
-	originalLocal := time.Local
-	time.Local = local
-	t.Cleanup(func() { time.Local = originalLocal })
-}