chore: somes clean

go-sprout · Sep 2, 2024 · 270cae4 · 270cae4
1 parent 14b9c54
commit 270cae4
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/registry/backward/functions_test.go b/registry/backward/functions_test.go
@@ -22,6 +22,7 @@ func TestUrlParse(t *testing.T) {
 		{Input: `{{ urlParse "https://example.com" | urlJoin }}`, ExpectedOutput: "https://example.com"},
 		{Input: `{{ urlParse "https://example.com/path" | urlJoin }}`, ExpectedOutput: "https://example.com/path"},
 		{Input: `{{ urlParse "https://user:pass@example.com/path?query=1" | urlJoin }}`, ExpectedOutput: "https://user:pass@example.com/path?query=1"},
+		{Input: `{{ urlParse "://" }}`, ExpectedErr: "unable to parse url"},
 	}
 
 	pesticide.RunTestCases(t, backward.NewRegistry(), tc)

diff --git a/registry/random/functions.go b/registry/random/functions.go
@@ -87,14 +87,17 @@ func (rr *RandomRegistry) RandNumeric(count int) string {
 // Example:
 //
 //	{{ 16 | randBytes }} // Output: "c3RhY2thYnVzZSByb2NrcyE=" (output will vary)
-func (rr *RandomRegistry) RandBytes(count int) string {
+func (rr *RandomRegistry) RandBytes(count int) (string, error) {
 	if count <= 0 {
-		return ""
+		return "", nil
 	}
 
 	buf := make([]byte, count)
-	_, _ = cryptorand.Read(buf)
-	return base64.StdEncoding.EncodeToString(buf)
+	_, err := cryptorand.Read(buf)
+	if err != nil {
+		return "", err
+	}
+	return base64.StdEncoding.EncodeToString(buf), nil
 }
 
 // RandInt generates a random integer between the specified minimum and maximum

diff --git a/registry/reflect/functions.go b/registry/reflect/functions.go
@@ -24,7 +24,7 @@ import (
 //
 //	{{ "int", 42 | typeIs }} // Output: true
 func (rr *ReflectRegistry) TypeIs(target string, src any) bool {
-	return rr.TypeOf(src) == target
+	return target == rr.TypeOf(src)
 }
 
 // TypeIsLike compares the type of 'src' to a target type string 'target',