Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: using errors.As instead of type assertion #1346

Merged
merged 1 commit into from
Feb 12, 2025
Merged

chore: using errors.As instead of type assertion #1346

merged 1 commit into from
Feb 12, 2025
+43 −36

Conversation

fatelei
Copy link
Contributor

@fatelei fatelei commented Dec 17, 2024

Fixes Or Enhances

fix issue #763

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@fatelei fatelei requested a review from a team as a code owner December 17, 2024 14:40
@coveralls
Copy link

coveralls commented Dec 17, 2024 •
edited
Loading

Coverage Status

coverage: 74.318%. remained the same
when pulling d7356f1 on fatelei:issue-743
into 6c3307e on go-playground:master.

@nodivbyzero
Copy link
Contributor

How does this change fix the issue #763?
image

ccoVeille
ccoVeille suggested changes Dec 17, 2024
View reviewed changes
_examples/simple/main.go Outdated Show resolved Hide resolved
_examples/struct-level/main.go Outdated Show resolved Hide resolved
deankarn
deankarn approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@deankarn deankarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now that it's using errors.As

@nodivbyzero nodivbyzero merged commit e564451 into go-playground:master Feb 12, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccoVeille ccoVeille ccoVeille approved these changes

@deankarn deankarn deankarn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fatelei @coveralls @nodivbyzero @ccoVeille @deankarn