fix ValidateMap and field references #1219
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jippi
commented
Feb 1, 2024
| return v.validateMapCtx(ctx, data, data, rules) | ||
| } | ||
|
|
||
| // validateMapCtx will track the original "root" map (in case of nesting) which will allow for Field reference validation |
There was a problem hiding this comment.
I was not sure how y'all prefer naming this, so I just lowercased the "inner loop" func here.
I also made this new func for the implementation, since the signature of the exported one would otherwise change - and it made said signature clunky having to pass in same var as root and data
jippi
commented
Feb 1, 2024
jippi
force-pushed
the
fix-ValidateMap-field-references
branch
from
ac59f8b to
48ccdec
Compare
jippi
force-pushed
the
fix-ValidateMap-field-references
branch
from
48ccdec to
0b97b35
Compare
|
bump on this one 🙏 |
|
bumping on this @deankarn |
ccoVeille
reviewed
Jul 13, 2024
| namespace = namespace[endIdx+1:] | ||
| // If we exceeded the length of the namespace, then we're at the end | ||
| // of the namespace traversal, so set it to empty value to break loop | ||
| if endIdx+1 > len(namespace) { |
There was a problem hiding this comment.
Is this code formatted ?
I would expect
Suggested change
| if endIdx+1 > len(namespace) { | |
| if endIdx + 1 > len(namespace) { |
Maybe I'm wrong, but a gofmt might help
| ctag := v.fetchCacheTag(tag) | ||
|
|
||
| val := reflect.ValueOf(field) | ||
| vd := v.pool.Get().(*validate) |
There was a problem hiding this comment.
No type assertion check here?
Suggested change
| vd := v.pool.Get().(*validate) | |
| vd, ok := v.pool.Get().(*validate) | |
| if !ok { | |
| return nil | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Or Enhances
Implement support for
ValidateMapusingFieldreferencesFixes #893
Fixes #876
Fixes #943
Make sure that you've checked the boxes below before you submit PR:
@go-playground/validator-maintainers